Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2398703002: S390: Change printf format specifier for size_t in heap.cc (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, JoranSiu, john.yan, JaideepBajwa, michael_dawson, MTBrandyberry
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Change printf format specifier for size_t in heap.cc GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Using the appropriate macro (PRIuS) instead. R=mlippautz@chromium.org, hpayer@chromium.org BUG= Committed: https://crrev.com/8ba6686b207fe879b0d0c84279bfc054ab8f643c Cr-Commit-Position: refs/heads/master@{#40012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/heap/heap.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yangtian.zi
PTAL
4 years, 2 months ago (2016-10-05 18:26:42 UTC) #1
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-05 18:39:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398703002/1
4 years, 2 months ago (2016-10-05 18:58:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:45:02 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:45:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ba6686b207fe879b0d0c84279bfc054ab8f643c
Cr-Commit-Position: refs/heads/master@{#40012}

Powered by Google App Engine
This is Rietveld 408576698