Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Side by Side Diff: src/crankshaft/hydrogen-instructions.cc

Issue 2398683004: [crankshaft] Remove HLoadNamedGeneric and use HCallWithDescriptor to call LoadIC. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen-instructions.h" 5 #include "src/crankshaft/hydrogen-instructions.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/ieee754.h" 8 #include "src/base/ieee754.h"
9 #include "src/base/safe_math.h" 9 #include "src/base/safe_math.h"
10 #include "src/crankshaft/hydrogen-infer-representation.h" 10 #include "src/crankshaft/hydrogen-infer-representation.h"
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 case HValue::kGoto: 796 case HValue::kGoto:
797 case HValue::kHasCachedArrayIndexAndBranch: 797 case HValue::kHasCachedArrayIndexAndBranch:
798 case HValue::kHasInstanceTypeAndBranch: 798 case HValue::kHasInstanceTypeAndBranch:
799 case HValue::kInnerAllocatedObject: 799 case HValue::kInnerAllocatedObject:
800 case HValue::kIsSmiAndBranch: 800 case HValue::kIsSmiAndBranch:
801 case HValue::kIsStringAndBranch: 801 case HValue::kIsStringAndBranch:
802 case HValue::kIsUndetectableAndBranch: 802 case HValue::kIsUndetectableAndBranch:
803 case HValue::kLeaveInlined: 803 case HValue::kLeaveInlined:
804 case HValue::kLoadFieldByIndex: 804 case HValue::kLoadFieldByIndex:
805 case HValue::kLoadNamedField: 805 case HValue::kLoadNamedField:
806 case HValue::kLoadNamedGeneric:
807 case HValue::kLoadRoot: 806 case HValue::kLoadRoot:
808 case HValue::kMathMinMax: 807 case HValue::kMathMinMax:
809 case HValue::kParameter: 808 case HValue::kParameter:
810 case HValue::kPhi: 809 case HValue::kPhi:
811 case HValue::kPushArguments: 810 case HValue::kPushArguments:
812 case HValue::kReturn: 811 case HValue::kReturn:
813 case HValue::kSeqStringGetChar: 812 case HValue::kSeqStringGetChar:
814 case HValue::kStoreCodeEntry: 813 case HValue::kStoreCodeEntry:
815 case HValue::kStoreKeyed: 814 case HValue::kStoreKeyed:
816 case HValue::kStoreNamedField: 815 case HValue::kStoreNamedField:
(...skipping 2058 matching lines...) Expand 10 before | Expand all | Expand 10 after
2875 os << "," << *maps()->at(i).handle(); 2874 os << "," << *maps()->at(i).handle();
2876 } 2875 }
2877 os << "]"; 2876 os << "]";
2878 } 2877 }
2879 2878
2880 if (HasDependency()) os << " " << NameOf(dependency()); 2879 if (HasDependency()) os << " " << NameOf(dependency());
2881 return os; 2880 return os;
2882 } 2881 }
2883 2882
2884 2883
2885 std::ostream& HLoadNamedGeneric::PrintDataTo(
2886 std::ostream& os) const { // NOLINT
2887 Handle<String> n = Handle<String>::cast(name());
2888 return os << NameOf(object()) << "." << n->ToCString().get();
2889 }
2890
2891
2892 std::ostream& HLoadKeyed::PrintDataTo(std::ostream& os) const { // NOLINT 2884 std::ostream& HLoadKeyed::PrintDataTo(std::ostream& os) const { // NOLINT
2893 if (!is_fixed_typed_array()) { 2885 if (!is_fixed_typed_array()) {
2894 os << NameOf(elements()); 2886 os << NameOf(elements());
2895 } else { 2887 } else {
2896 DCHECK(elements_kind() >= FIRST_FIXED_TYPED_ARRAY_ELEMENTS_KIND && 2888 DCHECK(elements_kind() >= FIRST_FIXED_TYPED_ARRAY_ELEMENTS_KIND &&
2897 elements_kind() <= LAST_FIXED_TYPED_ARRAY_ELEMENTS_KIND); 2889 elements_kind() <= LAST_FIXED_TYPED_ARRAY_ELEMENTS_KIND);
2898 os << NameOf(elements()) << "." << ElementsKindToString(elements_kind()); 2890 os << NameOf(elements()) << "." << ElementsKindToString(elements_kind());
2899 } 2891 }
2900 2892
2901 os << "[" << NameOf(key()); 2893 os << "[" << NameOf(key());
(...skipping 1129 matching lines...) Expand 10 before | Expand all | Expand 10 after
4031 case HObjectAccess::kExternalMemory: 4023 case HObjectAccess::kExternalMemory:
4032 os << "[external-memory]"; 4024 os << "[external-memory]";
4033 break; 4025 break;
4034 } 4026 }
4035 4027
4036 return os << "@" << access.offset(); 4028 return os << "@" << access.offset();
4037 } 4029 }
4038 4030
4039 } // namespace internal 4031 } // namespace internal
4040 } // namespace v8 4032 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698