Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2398653002: Presubmit recipe: commit the patch (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Presubmit recipe: call presubmit_support.py directly For some reason, presubmit_support.py can't find PRESUBMIT.py unless it has a diff. Calling this script directly allows us to specify a fake upstream to force it to find a diff and therefore be able to find PRESUBMIT.py. BUG=skia:5823 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2398653002 Committed: https://skia.googlesource.com/skia/+/c1c7c21fdd2793b2c03b8ffc06461a00c4241a18

Patch Set 1 #

Patch Set 2 : Call presubmit_support directly #

Patch Set 3 : Branch not needed? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -69 lines) Patch
M infra/bots/recipes/swarm_presubmit.py View 1 2 1 chunk +13 lines, -26 lines 0 comments Download
M infra/bots/recipes/swarm_presubmit.expected/presubmit.json View 1 2 3 chunks +3 lines, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
borenet
4 years, 2 months ago (2016-10-05 15:41:47 UTC) #4
rmistry
lgtm
4 years, 2 months ago (2016-10-05 16:25:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398653002/40001
4 years, 2 months ago (2016-10-05 16:34:46 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/c1c7c21fdd2793b2c03b8ffc06461a00c4241a18
4 years, 2 months ago (2016-10-05 16:52:45 UTC) #12
borenet
4 years, 2 months ago (2016-10-14 03:33:58 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2414133003/ by borenet@google.com.

The reason for reverting is: Instead of trying to run the presubmit for try jobs
and at every commit, let's do it only for try jobs, which worked fine without
this CL..

Powered by Google App Engine
This is Rietveld 408576698