Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2398633004: Build: Use wget instead of curl to download sysroots (Closed)

Created:
4 years, 2 months ago by Tom (Use chromium acct)
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build: Use wget instead of curl to download sysroots R=dpranke@chromium.org BUG=650482 Committed: https://crrev.com/afeed464143898afff1654acb2f47a69e50f86eb Cr-Commit-Position: refs/heads/master@{#423647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom (Use chromium acct)
4 years, 2 months ago (2016-10-06 19:49:15 UTC) #2
Dirk Pranke
lgtm. We could also replace this with ~10 lines of python code and not need ...
4 years, 2 months ago (2016-10-06 20:04:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398633004/1
4 years, 2 months ago (2016-10-06 20:11:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:18:44 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:20:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afeed464143898afff1654acb2f47a69e50f86eb
Cr-Commit-Position: refs/heads/master@{#423647}

Powered by Google App Engine
This is Rietveld 408576698