Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 8880b8d16d461c2e62b573e3bae7c445ab71a2b5..d878526bfd3af64a0f64531ea8edfe3335952347 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -6158,11 +6158,11 @@ void RenderFrameImpl::PopulateDocumentStateFromPending(
url::kJavaScriptScheme) &&
pending_navigation_params_->common_params.navigation_type ==
FrameMsg_Navigate_Type::RESTORE) {
- // We're doing a load of a page that was restored from the last session. By
- // default this prefers the cache over loading (LOAD_PREFERRING_CACHE) which
- // can result in stale data for pages that are set to expire. We explicitly
- // override that by setting the policy here so that as necessary we load
- // from the network.
+ // We're doing a load of a page that was restored from the last session.
+ // By default this prefers the cache over loading
+ // (LOAD_SKIP_CACHE_VALIDATION) which can result in stale data for pages
+ // that are set to expire. We explicitly override that by setting the
+ // policy here so that as necessary we load from the network.
//
// TODO(davidben): Remove this in favor of passing a cache policy to the
// loadHistoryItem call in OnNavigate. That requires not overloading

Powered by Google App Engine
This is Rietveld 408576698