Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: components/precache/core/precache_fetcher.cc

Issue 2398613002: [HttpCache] LOAD_ONLY_FROM_CACHE should not imply LOAD_PREFERRING_CACHE (Closed)
Patch Set: Always check vary Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/precache/core/precache_fetcher.h" 5 #include "components/precache/core/precache_fetcher.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 PrecacheFetcher::Fetcher::~Fetcher() {} 253 PrecacheFetcher::Fetcher::~Fetcher() {}
254 254
255 void PrecacheFetcher::Fetcher::LoadFromCache() { 255 void PrecacheFetcher::Fetcher::LoadFromCache() {
256 fetch_stage_ = FetchStage::CACHE; 256 fetch_stage_ = FetchStage::CACHE;
257 cache_url_fetcher_ = 257 cache_url_fetcher_ =
258 net::URLFetcher::Create(url_, net::URLFetcher::GET, this); 258 net::URLFetcher::Create(url_, net::URLFetcher::GET, this);
259 data_use_measurement::DataUseUserData::AttachToFetcher( 259 data_use_measurement::DataUseUserData::AttachToFetcher(
260 cache_url_fetcher_.get(), 260 cache_url_fetcher_.get(),
261 data_use_measurement::DataUseUserData::PRECACHE); 261 data_use_measurement::DataUseUserData::PRECACHE);
262 cache_url_fetcher_->SetRequestContext(request_context_); 262 cache_url_fetcher_->SetRequestContext(request_context_);
263 cache_url_fetcher_->SetLoadFlags(net::LOAD_ONLY_FROM_CACHE | kNoTracking); 263 cache_url_fetcher_->SetLoadFlags(net::LOAD_ONLY_FROM_CACHE |
264 net::LOAD_SKIP_CACHE_VALIDATION |
265 kNoTracking);
264 std::unique_ptr<URLFetcherNullWriter> null_writer(new URLFetcherNullWriter); 266 std::unique_ptr<URLFetcherNullWriter> null_writer(new URLFetcherNullWriter);
265 cache_url_fetcher_->SaveResponseWithWriter(std::move(null_writer)); 267 cache_url_fetcher_->SaveResponseWithWriter(std::move(null_writer));
266 cache_url_fetcher_->Start(); 268 cache_url_fetcher_->Start();
267 } 269 }
268 270
269 void PrecacheFetcher::Fetcher::LoadFromNetwork() { 271 void PrecacheFetcher::Fetcher::LoadFromNetwork() {
270 fetch_stage_ = FetchStage::NETWORK; 272 fetch_stage_ = FetchStage::NETWORK;
271 network_url_fetcher_ = 273 network_url_fetcher_ =
272 net::URLFetcher::Create(url_, net::URLFetcher::GET, this); 274 net::URLFetcher::Create(url_, net::URLFetcher::GET, this);
273 data_use_measurement::DataUseUserData::AttachToFetcher( 275 data_use_measurement::DataUseUserData::AttachToFetcher(
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
764 remaining = 0; 766 remaining = 0;
765 quota_.set_remaining( 767 quota_.set_remaining(
766 used_bytes > quota_.remaining() ? 0U : quota_.remaining() - used_bytes); 768 used_bytes > quota_.remaining() ? 0U : quota_.remaining() - used_bytes);
767 db_task_runner_->PostTask( 769 db_task_runner_->PostTask(
768 FROM_HERE, 770 FROM_HERE,
769 base::Bind(&PrecacheDatabase::SaveQuota, precache_database_, quota_)); 771 base::Bind(&PrecacheDatabase::SaveQuota, precache_database_, quota_));
770 } 772 }
771 } 773 }
772 774
773 } // namespace precache 775 } // namespace precache
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/threat_details_cache.cc ('k') | components/precache/core/precache_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698