Do not de-select text across continuations

third_party/WebKit/Source/core/layout/LayoutInline.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 918 matching lines @@
     updateHitTestResult(result, adjustedLocation.point());
     if (result.addNodeToListBasedTestResult(node(), adjustedLocation,
                                             regionResult) == StopHitTesting)
       return true;
   }
   return false;
 }
 
 PositionWithAffinity LayoutInline::positionForPoint(const LayoutPoint& point) {
   // FIXME: Does not deal with relative positioned inlines (should it?)
-  LayoutBlock* cb = containingBlock();
+
+  // If there are continuations, test them first because our containing block
+  // will not check them.
+  LayoutBoxModelObject* continuation = this->continuation();
+  while (continuation) {
+    if (continuation->isInline() || continuation->slowFirstChild())
+      return continuation->positionForPoint(point);
+    continuation = toLayoutBlockFlow(continuation)->inlineElementContinuation();
+  }
+
   if (firstLineBoxIncludingCulling()) {
     // This inline actually has a line box.  We must have clicked in the border/padding of one of these boxes.  We
     // should try to find a result by asking our containing block.
-    return cb->positionForPoint(point);
-  }
-
-  // Translate the coords from the pre-anonymous block to the post-anonymous block.

[pdr., 2016/10/06 04:52:32]

This code was added in 2007 in
https://chromium.googlesource.com/chromium/src/+/e2f61b1719b9254e7e3b6b542d41...
without much information or tests. I've added tests to cover what this might
have been intending. I did not find any existing layout test covers this
codepath.

-  LayoutPoint parentBlockPoint = cb->location() + point;
-  LayoutBoxModelObject* c = continuation();
-  while (c) {
-    LayoutBox* contBlock =
-        c->isInline() ? c->containingBlock() : toLayoutBlock(c);
-    if (c->isInline() || c->slowFirstChild())
-      return c->positionForPoint(parentBlockPoint -
-                                 contBlock->locationOffset());
-    c = toLayoutBlockFlow(c)->inlineElementContinuation();
+    return containingBlock()->positionForPoint(point);
   }
 
   return LayoutBoxModelObject::positionForPoint(point);
 }
 
 namespace {
 
 class LinesBoundingBoxGeneratorContext {
  public:
   LinesBoundingBoxGeneratorContext(FloatRect& rect) : m_rect(rect) {}
@@ skipping 553 matching lines @@
     paintInvalidator.invalidateDisplayItemClient(*box, invalidationReason);
 }
 
 // TODO(lunalu): Not to just dump 0, 0 as the x and y here
 LayoutRect LayoutInline::debugRect() const {
   IntRect linesBox = enclosingIntRect(linesBoundingBox());
   return LayoutRect(IntRect(0, 0, linesBox.width(), linesBox.height()));
 }
 
 }  // namespace blink