Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Issue 2398573002: Add RAPPOR metric for sites not reporting first meaningful paint (Closed)

Created:
4 years, 2 months ago by Kunihiko Sakamoto
Modified:
4 years, 2 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add RAPPOR metric for sites not reporting first meaningful paint First Meaningful Paint UMA is not recorded on >20% of page loads. This RAPPOR metric will help identify top sites that fail to report First Meaningful Paint. BUG=632081 Committed: https://crrev.com/76351a9a523c5d103a21901b0e13046e80447ad3 Cr-Commit-Position: refs/heads/master@{#423387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -16 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 2 chunks +28 lines, -16 lines 0 comments Download
M tools/metrics/rappor/rappor.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Kunihiko Sakamoto
4 years, 2 months ago (2016-10-05 08:49:58 UTC) #6
Charlie Harrison
Can these just be simple boolean RAPPOR metrics instead of multi-dimensional ones? Adding the multi-dimensionality ...
4 years, 2 months ago (2016-10-05 12:23:01 UTC) #8
Steven Holte
On 2016/10/05 12:23:01, Charlie Harrison wrote: > Can these just be simple boolean RAPPOR metrics ...
4 years, 2 months ago (2016-10-05 19:05:27 UTC) #9
Charlie Harrison
Gah that's what I get for reviewing code when I just wake up :P LGTM
4 years, 2 months ago (2016-10-05 19:08:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398573002/1
4 years, 2 months ago (2016-10-06 01:38:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 01:45:44 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:50:07 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76351a9a523c5d103a21901b0e13046e80447ad3
Cr-Commit-Position: refs/heads/master@{#423387}

Powered by Google App Engine
This is Rietveld 408576698