ui/android/java/res/values/dimens.xml - Issue 2398543003: Move Android view based ColorPicker from ui/ to components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/values/dimens.xml

Issue 2398543003: Move Android view based ColorPicker from ui/ to components/ (Closed)

Patch Set: add owners Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2013 The Chromium Authors. All rights reserved.

3	3

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <resources>	7 <resources>

8

9 <!--

10 14.5 = Seekbar thumb width - border width, but it depends on the width

11 of the seek bar icon.

12 -->

13 <dimen name="color_picker_gradient_margin">14.5dp</dimen>

14 <dimen name="color_button_height">60dp</dimen>

15 <dimen name="dropdown_item_height">50dp</dimen>	8 <dimen name="dropdown_item_height">50dp</dimen>

16 <dimen name="dropdown_item_divider_height">1px</dimen>	9 <dimen name="dropdown_item_divider_height">1px</dimen>

17	10

18 <!--	11 <!--

19 Fallback values if the corresponding com.android.internal.R dimensions	12 Fallback values if the corresponding com.android.internal.R dimensions

20 cannot be retrieved by name.	13 cannot be retrieved by name.

21 Note: Constants taken directly from Android's core/res/values/config.xm l.	14 Note: Constants taken directly from Android's core/res/values/config.xm l.

22 -->	15 -->

23 <dimen name="config_min_scaling_span">12.0mm</dimen>	16 <dimen name="config_min_scaling_span">12.0mm</dimen>

24 </resources>	17 </resources>

OLD	NEW