components/web_contents_delegate_android/android/java/res/values/dimens.xml - Issue 2398543003: Move Android view based ColorPicker from ui/ to components/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/web_contents_delegate_android/android/java/res/values/dimens.xml

Issue 2398543003: Move Android view based ColorPicker from ui/ to components/ (Closed)

Patch Set: move to components/ instead Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright (c) 2016 The Chromium Authors. All rights reserved.
	Ted C 2016/11/08 17:02:38 no (c) no (c) wychen 2016/11/08 21:20:33 Done. '(c)' is all over the place. Do we also want Show quoted text On 2016/11/08 17:02:38, Ted C wrote: > no (c) Done. '(c)' is all over the place. Do we also want to get rid of them to keep the style consistent? Ted C 2016/11/08 21:35:16 Nah, we should just not add new ones. Show quoted text On 2016/11/08 21:20:33, wychen wrote: > On 2016/11/08 17:02:38, Ted C wrote: > > no (c) > > Done. '(c)' is all over the place. Do we also want to get rid of them to keep > the style consistent? Nah, we should just not add new ones.
	3

	4 Use of this source code is governed by a BSD-style license that can be

	5 found in the LICENSE file.

	6 -->

	7

	8 <resources>

	9 <!--

	10 14.5 = Seekbar thumb width - border width, but it depends on the width

	11 of the seek bar icon.

	12 -->

	13 <dimen name="color_picker_gradient_margin">14.5dp</dimen>

	14 <dimen name="color_button_height">60dp</dimen>

	15 </resources>

OLD	NEW