Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2398493002: DevTools: [Persistence] split out WI.DefaultMapping (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Persistence] split out WI.DefaultMapping This patch splits out mapping logic from WI.Persistence. In future, the automapping implementation will be instantiated instead of DefaultMapping. BUG=none R=dgozman Committed: https://crrev.com/7b8da57fdf6012c30a7712ea2f425a1579066204 Cr-Commit-Position: refs/heads/master@{#423080}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -103 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js View 1 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
A third_party/WebKit/Source/devtools/front_end/persistence/DefaultMapping.js View 1 1 chunk +144 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Persistence.js View 6 chunks +6 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
lushnikov
please, take a look
4 years, 2 months ago (2016-10-05 01:40:04 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2398493002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js (right): https://codereview.chromium.org/2398493002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js#newcode20 third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:20: for (uiSourceCode of WebInspector.workspace.uiSourceCodes()) { for (var uiSourceCode ...
4 years, 2 months ago (2016-10-05 02:25:24 UTC) #4
lushnikov
All done, thanks https://codereview.chromium.org/2398493002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js (right): https://codereview.chromium.org/2398493002/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js#newcode20 third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-test.js:20: for (uiSourceCode of WebInspector.workspace.uiSourceCodes()) { On ...
4 years, 2 months ago (2016-10-05 03:55:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398493002/20001
4 years, 2 months ago (2016-10-05 03:55:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 05:17:30 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 05:19:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b8da57fdf6012c30a7712ea2f425a1579066204
Cr-Commit-Position: refs/heads/master@{#423080}

Powered by Google App Engine
This is Rietveld 408576698