Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2398473002: DevTools: Allow smart enter to be used in ConsolePrompt while Debugging (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow smart enter to be used in ConsolePrompt while Debugging BUG=244032 Committed: https://crrev.com/cca1838ddf9fbbd04ce5570112a52674e7362851 Cr-Commit-Position: refs/heads/master@{#423067}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-05 00:02:46 UTC) #2
einbinder
https://codereview.chromium.org/2398473002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js File third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js (right): https://codereview.chromium.org/2398473002/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js#newcode188 third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js:188: if (exceptionDetails && (exceptionDetails.exception.description.startsWith("SyntaxError: Unexpected end of input") When ...
4 years, 2 months ago (2016-10-05 00:04:34 UTC) #3
dgozman
lgtm
4 years, 2 months ago (2016-10-05 02:17:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398473002/1
4 years, 2 months ago (2016-10-05 02:17:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 03:45:46 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 03:49:03 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cca1838ddf9fbbd04ce5570112a52674e7362851
Cr-Commit-Position: refs/heads/master@{#423067}

Powered by Google App Engine
This is Rietveld 408576698