Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2398463005: Revert of 📰 Use the separate button style for the NoArticles status (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer, dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 📰 Use the separate button style for the NoArticles status (patchset #6 id:100001 of https://codereview.chromium.org/2392943002/ ) Reason for revert: Breaking tests on Android bots, see bug comment. Original issue's description: > [NTP Client] Use the separate button style for the NoArticles status > > Makes the articles and bookmarks sections use the same style of status > card when they have no snippets. > > the hasMoreButton property of categories now only determines whether > the action item will be shown when there are suggestions to display. > > This patch also lets the SuggestionsCategoryInfo be aware of the > current category it is describing, and moves various category specific > behaviours into the SuggestionsCategoryInfo class. > > Preview: https://goo.gl/photos/VhceT6cjvME6QS8m7 > > BUG=649670 > > Committed: https://crrev.com/ffa8e3905fed0b1df0d56ab6e4b17791b31cd171 > Cr-Commit-Position: refs/heads/master@{#423517} TBR=bauerb@chromium.org,dgn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649670 Committed: https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c Cr-Commit-Position: refs/heads/master@{#423573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -208 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java View 4 chunks +23 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 2 chunks +94 lines, -9 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsCategoryInfo.java View 4 chunks +3 lines, -68 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 6 chunks +37 lines, -17 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 24 chunks +113 lines, -71 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java View 4 chunks +30 lines, -18 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets_strings.grdp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Theresa
Created Revert of 📰 Use the separate button style for the NoArticles status
4 years, 2 months ago (2016-10-06 17:33:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398463005/1
4 years, 2 months ago (2016-10-06 17:34:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 17:35:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b5e8956c2c8a10484d10a117b3ef5a33ee58cb6c Cr-Commit-Position: refs/heads/master@{#423573}
4 years, 2 months ago (2016-10-06 17:37:59 UTC) #6
dgn
4 years, 2 months ago (2016-10-07 09:43:11 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2401643004/ by dgn@chromium.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698