Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Issue 2398463003: 16 bit capture and GPU&CPU memory buffer support.

Created:
4 years, 2 months ago by aleksandar.stojiljkovic
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, cc-bugs_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

16 bit capture and GPU&CPU memory buffer support. Windows, Linux and ChromeOS support. BUG=624436 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Patch Set 1 #

Patch Set 2 : fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -335 lines) Patch
M cc/resources/video_resource_updater.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/gpu_memory_buffer_tracker.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_event_handler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 15 chunks +62 lines, -62 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/media/video_capture_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 6 chunks +34 lines, -25 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/video_frame.h View 2 chunks +14 lines, -0 lines 0 comments Download
M media/base/video_frame.cc View 7 chunks +56 lines, -5 lines 0 comments Download
M media/capture/BUILD.gn View 2 chunks +10 lines, -2 lines 0 comments Download
D media/capture/video/blob_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D media/capture/video/blob_utils.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M media/capture/video/fake_video_capture_device.h View 2 chunks +4 lines, -1 line 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.cc View 4 chunks +14 lines, -5 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 7 chunks +20 lines, -13 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.cc View 3 chunks +24 lines, -4 lines 0 comments Download
M media/capture/video/video_capture_device_client.cc View 1 5 chunks +64 lines, -19 lines 0 comments Download
M media/capture/video/video_capture_device_unittest.cc View 2 chunks +19 lines, -0 lines 0 comments Download
A + media/capture/video/video_capture_utils.h View 1 2 chunks +9 lines, -3 lines 0 comments Download
A + media/capture/video/video_capture_utils.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M media/capture/video/win/sink_input_pin_win.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M media/capture/video/win/video_capture_device_factory_win.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/capture/video/win/video_capture_device_mf_win.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M media/capture/video/win/video_capture_device_win.cc View 2 chunks +4 lines, -1 line 0 comments Download
M media/renderers/gpu_video_accelerator_factories.h View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 20 chunks +110 lines, -62 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
aleksandar.stojiljkovic
media and content code split from 2121043002: (8 and 16 bpp video stream capture and ...
4 years, 2 months ago (2016-10-05 04:26:53 UTC) #7
aleksandar.stojiljkovic
+hubbe@ for Owner review of media/video/gpu_memory_buffer_video_frame_pool.cc. Thanks
4 years, 2 months ago (2016-10-05 18:09:45 UTC) #9
hubbe
On 2016/10/05 18:09:45, aleksandar.stojiljkovic wrote: > +hubbe@ > for Owner review of media/video/gpu_memory_buffer_video_frame_pool.cc. > Thanks ...
4 years, 2 months ago (2016-10-05 18:23:22 UTC) #10
aleksandar.stojiljkovic
On 2016/10/05 18:23:22, hubbe wrote: > On 2016/10/05 18:09:45, aleksandar.stojiljkovic wrote: > > +hubbe@ > ...
4 years, 2 months ago (2016-10-05 18:47:34 UTC) #12
aleksandar.stojiljkovic
4 years, 2 months ago (2016-10-07 14:21:15 UTC) #13
On 2016/10/05 18:47:34, aleksandar.stojiljkovic wrote:
> On 2016/10/05 18:23:22, hubbe wrote:
> > On 2016/10/05 18:09:45, aleksandar.stojiljkovic wrote:
> > > +hubbe@
> > > for Owner review of media/video/gpu_memory_buffer_video_frame_pool.cc.
> > > Thanks
> > 
> > I think you'd be better off sending this to mailto:dcastagna@chromium.org,
> he's
> > currently reviewing my CL that touch this file... :)
> Thanks.
> +dcastagna@
> for Owner review of media/video/gpu_memory_buffer_video_frame_pool.cc.

I'm not able to fix the failing
WebRtcGetUserMediaBrowserTest.GetUserMediaWithMandatorySourceID without
rendering changes in original patch (2121043002) because it uses all fake
capture devices (also 16 bit stream). My idea of splitting 2121043002 for easier
review wasn't that good.
Closing this one and moving review to original patch.

Powered by Google App Engine
This is Rietveld 408576698