Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2398433002: aw: Avoid hold and wait deadlock (Closed)

Created:
4 years, 2 months ago by boliu
Modified:
4 years, 2 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Avoid hold and wait deadlock when creating single instances. Instead of using more locks which complicates things, just create the singletons during the webview init phoase. Only exception here is WebViewDatabas, which really is a standalone database and has nothing to do with the webview itself, but takes a Context in its constructor. The constructor currently is safe to be called from non-UI thread, so just do that. BUG=648784 Committed: https://crrev.com/7d528aede8d842cbfdf29d99ba6b6869a127fc81 Cr-Commit-Position: refs/heads/master@{#423156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -51 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 7 chunks +14 lines, -41 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserContext.java View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
boliu
ptal
4 years, 2 months ago (2016-10-04 21:25:46 UTC) #2
Torne
LGTM - this seems like the best option by far, and I can't see any ...
4 years, 2 months ago (2016-10-05 13:56:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398433002/1
4 years, 2 months ago (2016-10-05 14:35:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 14:42:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 14:44:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d528aede8d842cbfdf29d99ba6b6869a127fc81
Cr-Commit-Position: refs/heads/master@{#423156}

Powered by Google App Engine
This is Rietveld 408576698