Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2398413002: [regexp] Extract code to regexp-utils.{h,cc} (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Extract code to regexp-utils.{h,cc} This CL is in preparation for the upcoming port of RegExp.prototype.replace, which will need use these methods in runtime-regexp.cc. Moving them in advance makes that diff less noisy. BUG=v8:5339 Committed: https://crrev.com/760328f229dcfe4629cdaa469bcf097451f763aa Cr-Commit-Position: refs/heads/master@{#40229}

Patch Set 1 #

Patch Set 2 : Move IsRegExp to RegExpUtils as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -256 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 1 19 chunks +63 lines, -229 lines 0 comments Download
M src/builtins/builtins-string.cc View 1 4 chunks +4 lines, -3 lines 0 comments Download
M src/objects.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/objects.cc View 1 1 chunk +0 lines, -20 lines 0 comments Download
A src/regexp/regexp-utils.h View 1 1 chunk +65 lines, -0 lines 0 comments Download
A src/regexp/regexp-utils.cc View 1 1 chunk +230 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
jgruber
4 years, 2 months ago (2016-10-07 08:48:23 UTC) #4
Yang
On 2016/10/07 08:48:23, jgruber wrote: lgtm.
4 years, 2 months ago (2016-10-07 10:52:40 UTC) #7
jgruber
The new patchset moves Object::IsRegExp (which was only recently moved to Object) to RegExpUtils as ...
4 years, 2 months ago (2016-10-12 10:58:15 UTC) #10
Yang
On 2016/10/12 10:58:15, jgruber wrote: > The new patchset moves Object::IsRegExp (which was only recently ...
4 years, 2 months ago (2016-10-12 10:59:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398413002/20001
4 years, 2 months ago (2016-10-12 15:13:55 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 15:15:38 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:15:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/760328f229dcfe4629cdaa469bcf097451f763aa
Cr-Commit-Position: refs/heads/master@{#40229}

Powered by Google App Engine
This is Rietveld 408576698