Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h

Issue 2398373002: Construct KeyframeEffectReadOnly objects (Closed)
Patch Set: Test tweaks in response to review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
index a7718f685c5567072b912bc2d0374d27afb17331..2077d3023d3ac8953f5fc89fba708319215d45e3 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
@@ -27,6 +27,12 @@ class CORE_EXPORT KeyframeEffectReadOnly : public AnimationEffectReadOnly {
public:
enum Priority { DefaultPriority, TransitionPriority };
+ static KeyframeEffectReadOnly* create(Element*,
+ EffectModel*,
+ const Timing&,
+ Priority = DefaultPriority,
+ EventDelegate* = nullptr);
+ // Web Animations API Bindings constructors.
static KeyframeEffectReadOnly* create(
ExecutionContext*,
Element*,
@@ -111,8 +117,6 @@ class CORE_EXPORT KeyframeEffectReadOnly : public AnimationEffectReadOnly {
Vector<int> m_compositorAnimationIds;
};
-// TODO(suzyh): Replace calls to toKeyframeEffect with toKeyframeEffectReadOnly
-// where possible
DEFINE_TYPE_CASTS(KeyframeEffectReadOnly,
AnimationEffectReadOnly,
animationNode,

Powered by Google App Engine
This is Rietveld 408576698