Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/animation/ElementAnimations.cpp

Issue 2398373002: Construct KeyframeEffectReadOnly objects (Closed)
Patch Set: Test tweaks in response to review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/ElementAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
index baac68c92ec8479e5b605ba41b71fbbfcdb520e4..a3d309d024649b5aa876301d2cc4cb1dcbdf5325 100644
--- a/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
@@ -41,8 +41,9 @@ void ElementAnimations::updateAnimationFlags(ComputedStyle& style) {
const Animation& animation = *entry.key;
DCHECK(animation.effect());
// FIXME: Needs to consider AnimationGroup once added.
- DCHECK(animation.effect()->isKeyframeEffect());
- const KeyframeEffect& effect = *toKeyframeEffect(animation.effect());
+ DCHECK(animation.effect()->isKeyframeEffectReadOnly());
+ const KeyframeEffectReadOnly& effect =
+ *toKeyframeEffectReadOnly(animation.effect());
if (effect.isCurrent()) {
if (effect.affects(PropertyHandle(CSSPropertyOpacity)))
style.setHasCurrentOpacityAnimation(true);

Powered by Google App Engine
This is Rietveld 408576698