X11: Avoid round-tripping to get the cursor position

ui/views/widget/desktop_aura/desktop_screen_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_screen_x11.h"
 
+#include <X11/extensions/XInput2.h>
 #include <X11/extensions/Xrandr.h>
 #include <X11/Xlib.h>
 
 // It clashes with out RootWindow.
 #undef RootWindow
 
 #include "base/logging.h"
 #include "base/trace_event/trace_event.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/aura/window_tree_host.h"
 #include "ui/base/layout.h"
 #include "ui/display/display.h"
 #include "ui/display/display_finder.h"
 #include "ui/display/screen.h"
 #include "ui/display/util/display_util.h"
 #include "ui/display/util/x11/edid_parser_x11.h"
 #include "ui/events/platform/platform_event_source.h"
+#include "ui/events/platform/x11/x11_event_source.h"
 #include "ui/gfx/font_render_params.h"
 #include "ui/gfx/geometry/point_conversions.h"
 #include "ui/gfx/geometry/size_conversions.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/gfx/x/x11_types.h"
 #include "ui/views/linux_ui/linux_ui.h"
 #include "ui/views/widget/desktop_aura/desktop_screen.h"
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 #include "ui/views/widget/desktop_aura/x11_topmost_window_finder.h"
 
@@ skipping 91 matching lines @@
   if (has_xrandr_ && ui::PlatformEventSource::GetInstance())
     ui::PlatformEventSource::GetInstance()->RemovePlatformEventDispatcher(this);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // DesktopScreenX11, display::Screen implementation:
 
 gfx::Point DesktopScreenX11::GetCursorScreenPoint() {
   TRACE_EVENT0("views", "DesktopScreenX11::GetCursorScreenPoint()");
 
-  XDisplay* display = gfx::GetXDisplay();
+  const XEvent* event =
+      ui::X11EventSource::HasInstance()
+          ? ui::X11EventSource::GetInstance()->get_dispatching_event()
+          : nullptr;
+
+  if (event) {
+    switch (event->type) {
+      case ButtonPress:
+      case ButtonRelease:
+        return gfx::Point(event->xbutton.x_root, event->xbutton.y_root);
+      case MotionNotify:
+        return gfx::Point(event->xmotion.x_root, event->xmotion.y_root);
+      case EnterNotify:
+      case LeaveNotify:
+        return gfx::Point(event->xcrossing.x_root, event->xcrossing.y_root);
+      case GenericEvent:
+        const XIEvent* xi_event =

[Tom (Use chromium acct), 2016/10/07 00:23:18]

Do we need to check for deviceid or sourceid here?

[sadrul, 2016/10/07 02:12:51]

Probably check with TouchFactory first (like in
https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_win...)

[Tom (Use chromium acct), 2016/10/07 21:13:18]

Done.

+            static_cast<const XIEvent*>(event->xcookie.data);
+        switch (xi_event->evtype) {
+          case XI_ButtonPress:
+          case XI_ButtonRelease:
+          case XI_Motion: {
+            const XIDeviceEvent* device_event =
+                static_cast<const XIDeviceEvent*>(event->xcookie.data);
+            return gfx::Point(device_event->root_x, device_event->root_y);
+          }
+          case XI_Enter:
+          case XI_Leave: {
+            const XIEnterEvent* enter_event =
+                static_cast<const XIEnterEvent*>(event->xcookie.data);
+            return gfx::Point(enter_event->root_x, enter_event->root_y);
+          }

[Tom (Use chromium acct), 2016/10/07 00:23:18]

Do we also need to handle XI_Touch{Begin,Update,End}?

[sadrul, 2016/10/07 02:12:51]

Let's not. chrome generally expects that touch events do not affect the mouse
cursor.

[Tom (Use chromium acct), 2016/10/07 21:13:18]

Acknowledged.

+        }
+    }
+  }
 
   ::Window root, child;
   int root_x, root_y, win_x, win_y;
   unsigned int mask;
-  XQueryPointer(display,
-                DefaultRootWindow(display),
-                &root,
-                &child,
-                &root_x,
-                &root_y,
-                &win_x,
-                &win_y,
-                &mask);
+  XQueryPointer(xdisplay_, x_root_window_, &root, &child, &root_x, &root_y,
+                &win_x, &win_y, &mask);
 
   return PixelToDIPPoint(gfx::Point(root_x, root_y));
 }
 
 bool DesktopScreenX11::IsWindowUnderCursor(gfx::NativeWindow window) {
   return GetWindowAtScreenPoint(GetCursorScreenPoint()) == window;
 }
 
 gfx::NativeWindow DesktopScreenX11::GetWindowAtScreenPoint(
     const gfx::Point& point) {
@@ skipping 244 matching lines @@
       GetPrimaryDisplay().device_scale_factor());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 display::Screen* CreateDesktopScreen() {
   return new DesktopScreenX11;
 }
 
 }  // namespace views