Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2398313002: WebSQL: Add missing getExecutionContext() null check (Closed)

Created:
4 years, 2 months ago by jsbell
Modified:
4 years, 2 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebSQL: Add missing getExecutionContext() null check Following r419951 getExecutionContext() may return null, so return value must be checked. BUG=653272 R=haraken@chromium.org Committed: https://crrev.com/6584c5e9bdbc3af9f7995a25252d5b4ef802e7c9 Cr-Commit-Position: refs/heads/master@{#423764}

Patch Set 1 #

Patch Set 2 : Use newfangled remove() method to simplify repro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
A third_party/WebKit/LayoutTests/storage/websql/database-removed-context-crash.html View 1 1 chunk +50 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/storage/websql/database-removed-context-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/storage/websql/transaction-removed-context-crash.html View 1 2 chunks +17 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jsbell
haraken@ - r? cq? Note that this repro is synchronous and really simple - just ...
4 years, 2 months ago (2016-10-06 23:22:03 UTC) #3
haraken
Thanks, LGTM!
4 years, 2 months ago (2016-10-06 23:29:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398313002/20001
4 years, 2 months ago (2016-10-06 23:29:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 00:42:54 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 00:46:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6584c5e9bdbc3af9f7995a25252d5b4ef802e7c9
Cr-Commit-Position: refs/heads/master@{#423764}

Powered by Google App Engine
This is Rietveld 408576698