Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: cc/trees/layer_tree_host_unittest_damage.cc

Issue 23983047: Pinch/Zoom Infrastructure & Plumbing CL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r248052. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_unittest_animation.cc ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_damage.cc
diff --git a/cc/trees/layer_tree_host_unittest_damage.cc b/cc/trees/layer_tree_host_unittest_damage.cc
index 9c1c91261409426069e484c741695a6c5f3c1bcf..eb91e53c882b1edf59ce7ed79030c6c502b1cc34 100644
--- a/cc/trees/layer_tree_host_unittest_damage.cc
+++ b/cc/trees/layer_tree_host_unittest_damage.cc
@@ -433,17 +433,23 @@ class LayerTreeHostScrollbarDamageTest : public LayerTreeHostDamageTest {
root_layer->SetMasksToBounds(true);
layer_tree_host()->SetRootLayer(root_layer);
+ scoped_refptr<Layer> scroll_clip_layer = Layer::Create();
scoped_refptr<Layer> content_layer = FakeContentLayer::Create(&client_);
- content_layer->SetScrollable(true);
+ content_layer->SetScrollClipLayerId(scroll_clip_layer->id());
content_layer->SetScrollOffset(gfx::Vector2d(10, 20));
- content_layer->SetMaxScrollOffset(gfx::Vector2d(30, 50));
content_layer->SetBounds(gfx::Size(100, 200));
- root_layer->AddChild(content_layer);
+ scroll_clip_layer->SetBounds(
+ gfx::Size(content_layer->bounds().width() - 30,
+ content_layer->bounds().height() - 50));
+ scroll_clip_layer->AddChild(content_layer);
+ root_layer->AddChild(scroll_clip_layer);
scoped_refptr<Layer> scrollbar_layer =
FakePaintedScrollbarLayer::Create(false, true, content_layer->id());
scrollbar_layer->SetPosition(gfx::Point(300, 300));
scrollbar_layer->SetBounds(gfx::Size(10, 100));
+ scrollbar_layer->ToScrollbarLayer()->SetClipLayer(scroll_clip_layer->id());
+ scrollbar_layer->ToScrollbarLayer()->SetScrollLayer(content_layer->id());
root_layer->AddChild(scrollbar_layer);
gfx::RectF content_rect(content_layer->position(),
@@ -502,7 +508,8 @@ class LayerTreeHostDamageTestScrollbarDoesDamage
++did_swaps_;
EXPECT_TRUE(result);
LayerImpl* root = host_impl->active_tree()->root_layer();
- LayerImpl* scroll_layer = root->children()[0];
+ LayerImpl* scroll_clip_layer = root->children()[0];
+ LayerImpl* scroll_layer = scroll_clip_layer->children()[0];
switch (did_swaps_) {
case 1:
// Test that modifying the position of the content layer (not
@@ -516,7 +523,8 @@ class LayerTreeHostDamageTestScrollbarDoesDamage
host_impl->SetNeedsRedraw();
break;
case 3:
- scroll_layer->SetMaxScrollOffset(gfx::Vector2d(60, 100));
+ scroll_layer->SetBounds(gfx::Size(root->bounds().width() + 60,
+ root->bounds().height() + 100));
host_impl->SetNeedsRedraw();
break;
}
@@ -576,7 +584,8 @@ class LayerTreeHostDamageTestScrollbarCommitDoesNoDamage
++did_swaps_;
EXPECT_TRUE(result);
LayerImpl* root = host_impl->active_tree()->root_layer();
- LayerImpl* scroll_layer = root->children()[0];
+ LayerImpl* scroll_clip_layer = root->children()[0];
+ LayerImpl* scroll_layer = scroll_clip_layer->children()[0];
switch (did_swaps_) {
case 1:
// Scroll on the thread. This should damage the scrollbar for the
« no previous file with comments | « cc/trees/layer_tree_host_unittest_animation.cc ('k') | cc/trees/layer_tree_host_unittest_scroll.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698