Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: cc/trees/layer_tree_host_unittest_damage.cc

Issue 23983047: Pinch/Zoom Infrastructure & Plumbing CL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Draft for review. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_unittest_damage.cc
diff --git a/cc/trees/layer_tree_host_unittest_damage.cc b/cc/trees/layer_tree_host_unittest_damage.cc
index 58644e63b50e1c077d8f794ff39e2b54ac9645cd..06db9ed8ba17e5a6aeb88374276009932f129491 100644
--- a/cc/trees/layer_tree_host_unittest_damage.cc
+++ b/cc/trees/layer_tree_host_unittest_damage.cc
@@ -422,17 +422,23 @@ class LayerTreeHostScrollbarDamageTest : public LayerTreeHostDamageTest {
root_layer->SetMasksToBounds(true);
layer_tree_host()->SetRootLayer(root_layer);
+ scoped_refptr<Layer> scroll_clip_layer = Layer::Create();
scoped_refptr<Layer> content_layer = FakeContentLayer::Create(&client_);
- content_layer->SetScrollable(true);
+ content_layer->SetScrollable(scroll_clip_layer.get());
content_layer->SetScrollOffset(gfx::Vector2d(10, 20));
- content_layer->SetMaxScrollOffset(gfx::Vector2d(30, 50));
content_layer->SetBounds(gfx::Size(100, 200));
- root_layer->AddChild(content_layer);
+ scroll_clip_layer->SetBounds(
+ gfx::Size(content_layer->bounds().width() - 30,
+ content_layer->bounds().height() - 50));
+ scroll_clip_layer->AddChild(content_layer);
+ root_layer->AddChild(scroll_clip_layer);
scoped_refptr<Layer> scrollbar_layer =
- FakePaintedScrollbarLayer::Create(false, true, content_layer->id());
+ FakePaintedScrollbarLayer::Create(false, true, content_layer.get());
scrollbar_layer->SetPosition(gfx::Point(300, 300));
scrollbar_layer->SetBounds(gfx::Size(10, 100));
+ scrollbar_layer->ToScrollbarLayer()->SetClipLayer(scroll_clip_layer);
+ scrollbar_layer->ToScrollbarLayer()->SetScrollLayer(content_layer);
root_layer->AddChild(scrollbar_layer);
gfx::RectF content_rect(content_layer->position(),
@@ -490,7 +496,8 @@ class LayerTreeHostDamageTestScrollbarDoesDamage
++did_swaps_;
EXPECT_TRUE(result);
LayerImpl* root = host_impl->active_tree()->root_layer();
- LayerImpl* scroll_layer = root->children()[0];
+ LayerImpl* scroll_clip_layer = root->children()[0];
+ LayerImpl* scroll_layer = scroll_clip_layer->children()[0];
switch (did_swaps_) {
case 1:
// Test that modifying the position of the content layer (not
@@ -504,7 +511,8 @@ class LayerTreeHostDamageTestScrollbarDoesDamage
host_impl->SetNeedsRedraw();
break;
case 3:
- scroll_layer->SetMaxScrollOffset(gfx::Vector2d(60, 100));
+ scroll_layer->SetBounds(gfx::Size(root->bounds().width() + 60,
+ root->bounds().height() + 100));
host_impl->SetNeedsRedraw();
break;
}
@@ -563,7 +571,8 @@ class LayerTreeHostDamageTestScrollbarCommitDoesNoDamage
++did_swaps_;
EXPECT_TRUE(result);
LayerImpl* root = host_impl->active_tree()->root_layer();
- LayerImpl* scroll_layer = root->children()[0];
+ LayerImpl* scroll_clip_layer = root->children()[0];
+ LayerImpl* scroll_layer = scroll_clip_layer->children()[0];
switch (did_swaps_) {
case 1:
// Scroll on the thread. This should damage the scrollbar for the

Powered by Google App Engine
This is Rietveld 408576698