Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: cc/layers/solid_color_scrollbar_layer.cc

Issue 23983047: Pinch/Zoom Infrastructure & Plumbing CL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Draft for review. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/layers/solid_color_scrollbar_layer.cc
diff --git a/cc/layers/solid_color_scrollbar_layer.cc b/cc/layers/solid_color_scrollbar_layer.cc
index d9ed922e5d893e9744d23ad38ca2d98f0a91126e..196b7e86ab3779d10bf8275fc03a048a1b23e3eb 100644
--- a/cc/layers/solid_color_scrollbar_layer.cc
+++ b/cc/layers/solid_color_scrollbar_layer.cc
@@ -12,29 +12,35 @@ namespace cc {
scoped_ptr<LayerImpl> SolidColorScrollbarLayer::CreateLayerImpl(
LayerTreeImpl* tree_impl) {
+ const bool kIsOverlayScrollbar = true;
return SolidColorScrollbarLayerImpl::Create(
- tree_impl, id(), orientation(), thumb_thickness_,
- is_left_side_vertical_scrollbar_).PassAs<LayerImpl>();
+ tree_impl,
+ id(),
+ orientation(),
+ thumb_thickness_,
+ is_left_side_vertical_scrollbar_,
+ kIsOverlayScrollbar).PassAs<LayerImpl>();
}
scoped_refptr<SolidColorScrollbarLayer> SolidColorScrollbarLayer::Create(
ScrollbarOrientation orientation,
int thumb_thickness,
bool is_left_side_vertical_scrollbar,
- int scroll_layer_id) {
+ Layer* scroll_layer) {
return make_scoped_refptr(new SolidColorScrollbarLayer(
orientation,
thumb_thickness,
is_left_side_vertical_scrollbar,
- scroll_layer_id));
+ scroll_layer));
}
SolidColorScrollbarLayer::SolidColorScrollbarLayer(
ScrollbarOrientation orientation,
int thumb_thickness,
bool is_left_side_vertical_scrollbar,
- int scroll_layer_id)
- : scroll_layer_id_(scroll_layer_id),
+ Layer* scroll_layer)
+ : scroll_layer_(scroll_layer),
+ clip_layer_(NULL),
orientation_(orientation),
thumb_thickness_(thumb_thickness),
is_left_side_vertical_scrollbar_(is_left_side_vertical_scrollbar) {}
@@ -45,19 +51,42 @@ ScrollbarLayerInterface* SolidColorScrollbarLayer::ToScrollbarLayer() {
return this;
}
+void SolidColorScrollbarLayer::PushPropertiesTo(LayerImpl* layer) {
+ Layer::PushPropertiesTo(layer);
+ PushScrollClipPropertiesTo(layer);
+}
+
+void SolidColorScrollbarLayer::PushScrollClipPropertiesTo(LayerImpl* layer) {
+ SolidColorScrollbarLayerImpl* scrollbar_layer =
+ static_cast<SolidColorScrollbarLayerImpl*>(layer);
+
+ scrollbar_layer->SetScrollLayerById(scroll_layer_ ? scroll_layer_->id()
+ : Layer::INVALID_ID);
+ scrollbar_layer->SetClipLayerById(clip_layer_ ? clip_layer_->id()
+ : Layer::INVALID_ID);
+}
+
bool SolidColorScrollbarLayer::OpacityCanAnimateOnImplThread() const {
return true;
}
int SolidColorScrollbarLayer::ScrollLayerId() const {
- return scroll_layer_id_;
+ return scroll_layer_->id();
+}
+
+void SolidColorScrollbarLayer::SetScrollLayer(scoped_refptr<Layer> layer) {
+ if (layer == scroll_layer_)
+ return;
+
+ scroll_layer_ = layer;
+ SetNeedsFullTreeSync();
}
-void SolidColorScrollbarLayer::SetScrollLayerId(int id) {
- if (id == scroll_layer_id_)
+void SolidColorScrollbarLayer::SetClipLayer(scoped_refptr<Layer> layer) {
+ if (layer == clip_layer_)
return;
- scroll_layer_id_ = id;
+ clip_layer_ = layer;
SetNeedsFullTreeSync();
}

Powered by Google App Engine
This is Rietveld 408576698