Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 23983039: Merge 221688 "Implement put_accvalue for textfields and location..." (Closed)

Created:
7 years, 3 months ago by msw
Modified:
7 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, James Su, yusukes+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, nona+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Merge 221688 "Implement put_accvalue for textfields and location..." I encountered conflicts while merging location_bar_view.cc. I did not merge any of the function reordering from the original CL. (reduces merge footprint, avoids conflicts, retains functionality) Dominic, please review the merge at your earliest convenience. > Implement put_accvalue for textfields and location bar. > > All interactive views implement GetAccessibleState > to provide accessibility information about the current > state of the view. This struct now includes a callback > that can be used to change the string value, since > automation software wants to fill in text fields, > and this interface is implemented for Textfield > and LocationBarView, and hooked up to put_accValue. > > BUG=260266 > > Review URL: https://chromiumcodereview.appspot.com/23441024 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223525

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -17 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.h View 4 chunks +9 lines, -3 lines 1 comment Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 4 chunks +17 lines, -1 line 0 comments Download
M ui/base/accessibility/accessible_view_state.h View 2 chunks +12 lines, -0 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.cc View 3 chunks +20 lines, -8 lines 0 comments Download
A + ui/views/accessibility/native_view_accessibility_win_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 3 chunks +9 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 5 chunks +20 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
msw
7 years, 3 months ago (2013-09-17 03:41:04 UTC) #1
msw
Committed patchset #1 manually as r223525.
7 years, 3 months ago (2013-09-17 03:45:23 UTC) #2
dmazzoni
7 years, 3 months ago (2013-09-17 16:55:08 UTC) #3
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/23983039/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/location_bar_view.h (left):

https://codereview.chromium.org/23983039/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/location_bar_view.h:404: void
ToggleVisibility(bool new_vis, views::View* view);
For the record, this was never implemented and never called. It's a tiny cleanup
that I did as part of this change.

Powered by Google App Engine
This is Rietveld 408576698