[Android] Provide synchronized input flush with BeginFrame

content/browser/renderer_host/render_widget_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_impl.h"
 
 #include <math.h>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 208 matching lines @@
   // Otherwise we'll notify the process host when we are first shown.
   if (!hidden)
     process_->WidgetRestored();
 
   accessibility_mode_ =
       BrowserAccessibilityStateImpl::GetInstance()->accessibility_mode();
 
   for (size_t i = 0; i < g_created_callbacks.Get().size(); i++)
     g_created_callbacks.Get().at(i).Run(this);
 
-  input_router_.reset(
-      new ImmediateInputRouter(process_, this, this, routing_id_));
+  input_router_ = CreateInputRouter();
 
 #if defined(USE_AURA)
   bool overscroll_enabled = CommandLine::ForCurrentProcess()->
       GetSwitchValueASCII(switches::kOverscrollHistoryNavigation) != "0";
   SetOverscrollControllerEnabled(overscroll_enabled);
 #endif
 }
 
 RenderWidgetHostImpl::~RenderWidgetHostImpl() {
   SetView(NULL);
@@ skipping 171 matching lines @@
   if (!enabled)
     overscroll_controller_.reset();
   else if (!overscroll_controller_)
     overscroll_controller_.reset(new OverscrollController(this));
 }
 
 void RenderWidgetHostImpl::SuppressNextCharEvents() {
   suppress_next_char_events_ = true;
 }
 
+void RenderWidgetHostImpl::FlushInput() {
+  input_router_->Flush();
+}
+
 void RenderWidgetHostImpl::Init() {
   DCHECK(process_->HasConnection());
 
   renderer_initialized_ = true;
 
   GpuSurfaceTracker::Get()->SetSurfaceHandle(
       surface_id_, GetCompositingSurface());
 
   // Send the ack along with the information on placement.
   Send(new ViewMsg_CreatingNew_ACK(routing_id_));
@@ skipping 838 matching lines @@
 
 void RenderWidgetHostImpl::RendererExited(base::TerminationStatus status,
                                           int exit_code) {
   // Clearing this flag causes us to re-create the renderer when recovering
   // from a crashed renderer.
   renderer_initialized_ = false;
 
   waiting_for_screen_rects_ack_ = false;
 
   // Reset to ensure that input routing works with a new renderer.
-  input_router_.reset(
-      new ImmediateInputRouter(process_, this, this, routing_id_));
+  input_router_ = CreateInputRouter();
 
   if (overscroll_controller_)
     overscroll_controller_->Reset();
 
  // Must reset these to ensure that keyboard events work with a new renderer.
   suppress_next_char_events_ = false;
 
   // Reset some fields in preparation for recovering from a crash.
   ResetSizeAndRepaintPendingFlags();
   current_size_.SetSize(0, 0);
@@ skipping 853 matching lines @@
 }
 
 bool RenderWidgetHostImpl::OnSendGestureEventImmediately(
       const GestureEventWithLatencyInfo& gesture_event) {
   TRACE_EVENT_INSTANT0("input",
                        "RenderWidgetHostImpl::OnSendGestureEventImmediately",
                        TRACE_EVENT_SCOPE_THREAD);
   return !IgnoreInputEvents();
 }
 
 void RenderWidgetHostImpl::SetNeedsFlush() {

[brianderson, 2013/09/13 21:49:27]

I see that this function existed before, but was empty. Who calls this function?

[jdduke (slow), 2013/09/16 15:16:04]

Nobody, currently; this was added in the patch that added the
BufferedInputRouter. I wanted to keep that self-contained, and have the "wiring"
patch (this patch) separate.

+  if (view_)
+    view_->OnSetNeedsFlushInput();
 }
 
 void RenderWidgetHostImpl::DidFlush() {
+  if (view_)
+    view_->OnDidFlushInput();
 }
 
 void RenderWidgetHostImpl::OnKeyboardEventAck(
       const NativeWebKeyboardEvent& event,
       InputEventAckState ack_result) {
 #if defined(OS_MACOSX)
   if (!is_hidden() && view_ && view_->PostProcessEventForPluginIme(event))
     return;
 #endif
 
@@ skipping 279 matching lines @@
   // Clear the new_auto_size_ since the empty value is used as a flag to
   // indicate that no callback is in progress (i.e. without this line
   // DelayedAutoResized will not get called again).
   new_auto_size_.SetSize(0, 0);
   if (!should_auto_resize_)
     return;
 
   OnRenderAutoResized(new_size);
 }
 
+scoped_ptr<InputRouter> RenderWidgetHostImpl::CreateInputRouter() {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableBufferedInputRouter)) {
+    return scoped_ptr<InputRouter>(
+        new BufferedInputRouter(process_, this, this, routing_id_));
+  } else {
+    return scoped_ptr<InputRouter>(
+        new ImmediateInputRouter(process_, this, this, routing_id_));
+  }
+}
+
 void RenderWidgetHostImpl::DetachDelegate() {
   delegate_ = NULL;
 }
 
 void RenderWidgetHostImpl::ComputeTouchLatency(
     const ui::LatencyInfo& latency_info) {
   ui::LatencyInfo::LatencyComponent ui_component;
   ui::LatencyInfo::LatencyComponent rwh_component;
   ui::LatencyInfo::LatencyComponent acked_component;
 
@@ skipping 99 matching lines @@
     int process_id = (b->first.second >> 32) & 0xffffffff;
     RenderWidgetHost* rwh =
         RenderWidgetHost::FromID(process_id, routing_id);
     if (!rwh)
       continue;
     RenderWidgetHostImpl::From(rwh)->FrameSwapped(latency_info);
   }
 }
 
 }  // namespace content