[oilpan] Handlify Node raw pointers in html/ and subclasses of dom/LiveNodeList.

Source/core/html/HTMLFrameOwnerElement.h

 /*
  * Copyright (C) 2006, 2007, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 63 matching lines @@
     SandboxFlags m_sandboxFlags;
 };
 
 inline Result<HTMLFrameOwnerElement> toFrameOwnerElement(const Handle<Node>& node)
 {
     ASSERT_WITH_SECURITY_IMPLICATION(!node || node->isFrameOwnerElement());
     return Handle<HTMLFrameOwnerElement>::cast(node);
 }
 
 class SubframeLoadingDisabler {
+    DISALLOW_ALLOCATION()
 public:
-    explicit SubframeLoadingDisabler(Node* root)
+    explicit SubframeLoadingDisabler(const Handle<Node>& root)
         : m_root(root)
     {
         disabledSubtreeRoots().add(m_root);
     }
 
     ~SubframeLoadingDisabler()
     {
         disabledSubtreeRoots().remove(m_root);
     }
 
     static bool canLoadFrame(const Handle<HTMLFrameOwnerElement>& owner)
     {
-        for (Node* node = owner.raw(); node; node = node->parentOrShadowHostNode().handle().raw()) {
+        for (Handle<Node> node = owner; node; node = node->parentOrShadowHostNode()) {
+            HandleScope scope;
             if (disabledSubtreeRoots().contains(node))
                 return false;
         }
         return true;
     }
 
 private:
-    static HashSet<Node*>& disabledSubtreeRoots()
+    static HashSet<Member<Node> >& disabledSubtreeRoots()
     {
-        DEFINE_STATIC_LOCAL(HashSet<Node*>, nodes, ());
+        // All nodes in the collection are traced individually (via m_root).

[haraken, 2013/09/12 20:08:14]

This observation looks correct, but it's a bit fragile to rely on the fact.
Also, this kind of hack will confuse verification tools which we will implement
in the future.

How about just using CollectionRoot<HashSet<Member<Node>>> ?

+        DEFINE_STATIC_LOCAL(HashSet<Member<Node> >, nodes, ());
         return nodes;
     }
 
-    Node* m_root;
+    Handle<Node> m_root;
 };
 
 } // namespace WebCore
 
 #endif // HTMLFrameOwnerElement_h