Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: runtime/vm/deopt_instructions.cc

Issue 23983030: Fix bug with deoptimization of SIMD Uint32x4 values. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/deopt_instructions.h" 5 #include "vm/deopt_instructions.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/code_patcher.h" 8 #include "vm/code_patcher.h"
9 #include "vm/intermediate_language.h" 9 #include "vm/intermediate_language.h"
10 #include "vm/locations.h" 10 #include "vm/locations.h"
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 }; 442 };
443 443
444 444
445 // Deoptimization instruction moving an XMM register. 445 // Deoptimization instruction moving an XMM register.
446 class DeoptUint32x4FpuRegisterInstr: public DeoptInstr { 446 class DeoptUint32x4FpuRegisterInstr: public DeoptInstr {
447 public: 447 public:
448 explicit DeoptUint32x4FpuRegisterInstr(intptr_t reg_as_int) 448 explicit DeoptUint32x4FpuRegisterInstr(intptr_t reg_as_int)
449 : reg_(static_cast<FpuRegister>(reg_as_int)) {} 449 : reg_(static_cast<FpuRegister>(reg_as_int)) {}
450 450
451 virtual intptr_t from_index() const { return static_cast<intptr_t>(reg_); } 451 virtual intptr_t from_index() const { return static_cast<intptr_t>(reg_); }
452 virtual DeoptInstr::Kind kind() const { return kFloat32x4FpuRegister; } 452 virtual DeoptInstr::Kind kind() const { return kUint32x4FpuRegister; }
453 453
454 virtual const char* ToCString() const { 454 virtual const char* ToCString() const {
455 return Isolate::Current()->current_zone()->PrintToString( 455 return Isolate::Current()->current_zone()->PrintToString(
456 "%s(f32x4)", Assembler::FpuRegisterName(reg_)); 456 "%s(f32x4)", Assembler::FpuRegisterName(reg_));
457 } 457 }
458 458
459 void Execute(DeoptimizationContext* deopt_context, intptr_t* to_addr) { 459 void Execute(DeoptimizationContext* deopt_context, intptr_t* to_addr) {
460 simd128_value_t value = deopt_context->FpuRegisterValueAsSimd128(reg_); 460 simd128_value_t value = deopt_context->FpuRegisterValueAsSimd128(reg_);
461 *reinterpret_cast<RawSmi**>(to_addr) = Smi::New(0); 461 *reinterpret_cast<RawSmi**>(to_addr) = Smi::New(0);
462 Isolate::Current()->DeferUint32x4Materialization( 462 Isolate::Current()->DeferUint32x4Materialization(
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
1099 Smi* offset, 1099 Smi* offset,
1100 DeoptInfo* info, 1100 DeoptInfo* info,
1101 Smi* reason) { 1101 Smi* reason) {
1102 intptr_t i = index * kEntrySize; 1102 intptr_t i = index * kEntrySize;
1103 *offset ^= table.At(i); 1103 *offset ^= table.At(i);
1104 *info ^= table.At(i + 1); 1104 *info ^= table.At(i + 1);
1105 *reason ^= table.At(i + 2); 1105 *reason ^= table.At(i + 2);
1106 } 1106 }
1107 1107
1108 } // namespace dart 1108 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698