runtime/lib/mirrors_impl.dart - Issue 23983026: Fill in type arguments when creating an object from the mirrors or embedding API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23983026: Fill in type arguments when creating an object from the mirrors or embedding API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index acc701d7ed3ee3e7625c2799352a5a5402755c90..3f4400fbed625d7e597512535a1f0f343a11f6f0 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -683,6 +683,7 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl

}

return reflect(_invokeConstructor(_reflectee,

+ _reflectedType,

_n(constructorName),

arguments,

names));

@@ -739,7 +740,7 @@ class _LocalClassMirrorImpl extends _LocalObjectMirrorImpl

_invokeSetter(reflectee, setterName, value)

native 'ClassMirror_invokeSetter';

- static _invokeConstructor(reflectee, constructorName, arguments, argumentNames)

+ static _invokeConstructor(reflectee, type, constructorName, arguments, argumentNames)

native 'ClassMirror_invokeConstructor';

static _ClassMirror_type_variables(reflectee)

« runtime/lib/mirrors.cc ('K') | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | runtime/vm/object.h » ('J')