Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 23983007: Update unreviewed mass baselines from r11086 based on code changes overnight (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Update unreviewed mass baselines from r11086 based on code changes overnight BUG=skia:1578 These results had been mass-committed, without review. Given that they were unreviewed in the first place, they are just as valid now. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11097

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed_any_not_from_bug1578 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 7 chunks +7 lines, -7 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 7 chunks +7 lines, -7 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 7 chunks +7 lines, -7 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Debug/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download
M expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 8 chunks +8 lines, -8 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 3 chunks +3 lines, -3 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Not yet ready for review... I'll let you know when they are. https://codereview.chromium.org/23983007/diff/1/expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json File expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json ...
7 years, 3 months ago (2013-09-05 15:30:17 UTC) #1
epoger
Ready for review at patchset 2. > Next up, I will be filtering through these ...
7 years, 3 months ago (2013-09-05 15:42:55 UTC) #2
robertphillips
lgtm
7 years, 3 months ago (2013-09-05 16:21:38 UTC) #3
epoger
7 years, 3 months ago (2013-09-05 16:27:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r11097.

Powered by Google App Engine
This is Rietveld 408576698