Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 23983006: Added two histograms missing from histograms.xml. (Closed)

Created:
7 years, 3 months ago by beaudoin
Modified:
7 years, 3 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Added two histograms missing from histograms.xml. The histograms were added to Chrome in: https://codereview.chromium.org/23181006/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221496

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Moved ThumbnailFallbackRate to other CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
beaudoin
Just a quick aposteriori fix to histograms.xml. Should I wait before https://codereview.chromium.org/23874005/ makes it through ...
7 years, 3 months ago (2013-09-05 14:05:11 UTC) #1
Alexei Svitkine (slow)
Please merge this to the other CL, so that the change is atomic and add ...
7 years, 3 months ago (2013-09-05 14:26:39 UTC) #2
beaudoin
On 2013/09/05 14:26:39, Alexei Svitkine wrote: > Please merge this to the other CL, so ...
7 years, 3 months ago (2013-09-05 14:51:53 UTC) #3
Alexei Svitkine (slow)
LGTM, please update the CL title/description (no longer three histograms).
7 years, 3 months ago (2013-09-05 15:00:32 UTC) #4
beaudoin
On 2013/09/05 15:00:32, Alexei Svitkine wrote: > LGTM, please update the CL title/description (no longer ...
7 years, 3 months ago (2013-09-05 15:04:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/23983006/8001
7 years, 3 months ago (2013-09-05 15:05:05 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 19:40:32 UTC) #7
Message was sent while issue was closed.
Change committed as 221496

Powered by Google App Engine
This is Rietveld 408576698