| Index: net/disk_cache/entry_unittest.cc
|
| diff --git a/net/disk_cache/entry_unittest.cc b/net/disk_cache/entry_unittest.cc
|
| index a7e6d9ea5f282e7e3c7dac321dc4b04cd4cfe786..7ccaa563111eef8e8312fa6906f07257791cf1d3 100644
|
| --- a/net/disk_cache/entry_unittest.cc
|
| +++ b/net/disk_cache/entry_unittest.cc
|
| @@ -2427,7 +2427,7 @@ bool DiskCacheEntryTest::SimpleCacheMakeBadChecksumEntry(const char* key,
|
| scoped_refptr<net::IOBuffer> buffer(new net::IOBuffer(kDataSize));
|
| base::strlcpy(buffer->data(), data, kDataSize);
|
|
|
| - EXPECT_EQ(kDataSize, WriteData(entry, 0, 0, buffer.get(), kDataSize, false));
|
| + EXPECT_EQ(kDataSize, WriteData(entry, 1, 0, buffer.get(), kDataSize, false));
|
| entry->Close();
|
| entry = NULL;
|
|
|
| @@ -2439,9 +2439,8 @@ bool DiskCacheEntryTest::SimpleCacheMakeBadChecksumEntry(const char* key,
|
| base::CreatePlatformFile(entry_file0_path, flags, NULL, NULL);
|
| if (entry_file0 == base::kInvalidPlatformFileValue)
|
| return false;
|
| - int64 file_offset =
|
| - disk_cache::simple_util::GetFileOffsetFromKeyAndDataOffset(
|
| - key, kDataSize - 2);
|
| + int64 file_offset = disk_cache::simple_util::GetFileOffsetFromDataOffset(
|
| + key, kDataSize - 2, 1, 0);
|
| EXPECT_EQ(1, base::WritePlatformFile(entry_file0, file_offset, "X", 1));
|
| if (!base::ClosePlatformFile(entry_file0))
|
| return false;
|
| @@ -2465,10 +2464,10 @@ TEST_F(DiskCacheEntryTest, SimpleCacheBadChecksum) {
|
| ScopedEntryPtr entry_closer(entry);
|
|
|
| const int kReadBufferSize = 200;
|
| - EXPECT_GE(kReadBufferSize, entry->GetDataSize(0));
|
| + EXPECT_GE(kReadBufferSize, entry->GetDataSize(1));
|
| scoped_refptr<net::IOBuffer> read_buffer(new net::IOBuffer(kReadBufferSize));
|
| EXPECT_EQ(net::ERR_CACHE_CHECKSUM_MISMATCH,
|
| - ReadData(entry, 0, 0, read_buffer.get(), kReadBufferSize));
|
| + ReadData(entry, 1, 0, read_buffer.get(), kReadBufferSize));
|
| }
|
|
|
| // Tests that an entry that has had an IO error occur can still be Doomed().
|
| @@ -2487,10 +2486,10 @@ TEST_F(DiskCacheEntryTest, SimpleCacheErrorThenDoom) {
|
| ScopedEntryPtr entry_closer(entry);
|
|
|
| const int kReadBufferSize = 200;
|
| - EXPECT_GE(kReadBufferSize, entry->GetDataSize(0));
|
| + EXPECT_GE(kReadBufferSize, entry->GetDataSize(1));
|
| scoped_refptr<net::IOBuffer> read_buffer(new net::IOBuffer(kReadBufferSize));
|
| EXPECT_EQ(net::ERR_CACHE_CHECKSUM_MISMATCH,
|
| - ReadData(entry, 0, 0, read_buffer.get(), kReadBufferSize));
|
| + ReadData(entry, 1, 0, read_buffer.get(), kReadBufferSize));
|
|
|
| entry->Doom(); // Should not crash.
|
| }
|
| @@ -2590,7 +2589,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheNonOptimisticOperationsDontBlock) {
|
| CacheTestFillBuffer(write_buffer->data(), write_buffer->size(), false);
|
| CallbackTest write_callback(&helper, false);
|
| int ret = entry->WriteData(
|
| - 0,
|
| + 1,
|
| 0,
|
| write_buffer.get(),
|
| write_buffer->size(),
|
| @@ -2623,7 +2622,7 @@ TEST_F(DiskCacheEntryTest,
|
| CacheTestFillBuffer(write_buffer->data(), write_buffer->size(), false);
|
| CallbackTest write_callback(&helper, false);
|
| int ret = entry->WriteData(
|
| - 0,
|
| + 1,
|
| 0,
|
| write_buffer.get(),
|
| write_buffer->size(),
|
| @@ -2636,7 +2635,7 @@ TEST_F(DiskCacheEntryTest,
|
| new net::IOBufferWithSize(kBufferSize));
|
| CallbackTest read_callback(&helper, false);
|
| ret = entry->ReadData(
|
| - 0,
|
| + 1,
|
| 0,
|
| read_buffer.get(),
|
| read_buffer->size(),
|
| @@ -3122,7 +3121,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheInFlightTruncate) {
|
| ASSERT_EQ(net::OK, CreateEntry(key, &entry));
|
|
|
| EXPECT_EQ(kBufferSize,
|
| - WriteData(entry, 0, 0, write_buffer.get(), kBufferSize, false));
|
| + WriteData(entry, 1, 0, write_buffer.get(), kBufferSize, false));
|
| entry->Close();
|
| entry = NULL;
|
|
|
| @@ -3137,7 +3136,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheInFlightTruncate) {
|
| scoped_refptr<net::IOBuffer> read_buffer(new net::IOBuffer(kReadBufferSize));
|
| CallbackTest read_callback(&helper, false);
|
| EXPECT_EQ(net::ERR_IO_PENDING,
|
| - entry->ReadData(0,
|
| + entry->ReadData(1,
|
| 0,
|
| read_buffer.get(),
|
| kReadBufferSize,
|
| @@ -3151,7 +3150,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheInFlightTruncate) {
|
| CacheTestFillBuffer(truncate_buffer->data(), kReadBufferSize, false);
|
| CallbackTest truncate_callback(&helper, false);
|
| EXPECT_EQ(net::ERR_IO_PENDING,
|
| - entry->WriteData(0,
|
| + entry->WriteData(1,
|
| 0,
|
| truncate_buffer.get(),
|
| kReadBufferSize,
|
| @@ -3287,19 +3286,19 @@ TEST_F(DiskCacheEntryTest, SimpleCacheMultipleReadersCheckCRC2) {
|
| disk_cache::Entry* entry = NULL;
|
| ASSERT_EQ(net::OK, OpenEntry(key, &entry));
|
| ScopedEntryPtr entry_closer(entry);
|
| - EXPECT_EQ(1, ReadData(entry, 0, 0, read_buffer1.get(), 1));
|
| + EXPECT_EQ(1, ReadData(entry, 1, 0, read_buffer1.get(), 1));
|
|
|
| // Advance the 2nd reader by the same amount.
|
| disk_cache::Entry* entry2 = NULL;
|
| EXPECT_EQ(net::OK, OpenEntry(key, &entry2));
|
| ScopedEntryPtr entry2_closer(entry2);
|
| - EXPECT_EQ(1, ReadData(entry2, 0, 0, read_buffer2.get(), 1));
|
| + EXPECT_EQ(1, ReadData(entry2, 1, 0, read_buffer2.get(), 1));
|
|
|
| // Continue reading 1st.
|
| - EXPECT_GT(0, ReadData(entry, 0, 1, read_buffer1.get(), size));
|
| + EXPECT_GT(0, ReadData(entry, 1, 1, read_buffer1.get(), size));
|
|
|
| // This read should fail as well because we have previous read failures.
|
| - EXPECT_GT(0, ReadData(entry2, 0, 1, read_buffer2.get(), 1));
|
| + EXPECT_GT(0, ReadData(entry2, 1, 1, read_buffer2.get(), 1));
|
| DisableIntegrityCheck();
|
| }
|
|
|
|
|