Expose InlineTextBoxes in the accessibility tree.

Source/core/accessibility/AccessibilityNodeObject.cpp

 /*
 * Copyright (C) 2012, Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions
 * are met:
 *
 * 1.  Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 1359 matching lines @@
 
     // Elements that should not have children
     switch (roleValue()) {
     case ImageRole:
     case ButtonRole:
     case PopUpButtonRole:
     case CheckBoxRole:
     case RadioButtonRole:
     case TabRole:
     case ToggleButtonRole:
-    case StaticTextRole:
     case ListBoxOptionRole:
     case ScrollBarRole:
         return false;
+    case StaticTextRole:
+        if (!axObjectCache()->inlineTextBoxAccessibility())

[aboxhall, 2013/09/06 17:19:21]

return axObjectCache()->inlineTextBoxAccessibility() ? Or is it desirable to
fall through to the default here?

[dmazzoni, 2013/09/06 20:25:27]

I find it slightly more clear to have it fall through - i.e. read the code as
"StaticTextRole should not have children, unless the inlineTextBoxAccessibility
flag is on".

I would find "return axObjectCache()->inlineTextBoxAccessibility()" less clear,
given the comment at the top of the switch. But I could move the test outside of
the switch with its own comment if you think that would be more clear.

[aboxhall, 2013/09/06 20:51:12]

This is fine. I tend to prefer not to do things like "if (!condition) return
false else return true" but I agree it makes sense semantically here.

+            return false;
     default:
         return true;
     }
 }
 
 Element* AccessibilityNodeObject::actionElement() const
 {
     Node* node = this->node();
     if (!node)
         return 0;
@@ skipping 403 matching lines @@
         useTextUnderElement = true;
 
     if (useTextUnderElement) {
         String text = textUnderElement();
         if (!text.isEmpty())
             textOrder.append(AccessibilityText(text, ChildrenText));
     }
 }
 
 } // namespace WebCore