Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2398293002: Small fixes for WevRTC protocol in host (Closed)

Created:
4 years, 2 months ago by Sergey Ulanov
Modified:
4 years, 2 months ago
Reviewers:
Irfan
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small fixes for WevRTC protocol in host 1. Updated max bitrate to 100Mbps 2. Fixed encoder to update active region for key frames to ensure proper top-off BUG=645656 Committed: https://crrev.com/2c410d363fdeeaa4551a4ed39526b8c065fea7d3 Cr-Commit-Position: refs/heads/master@{#423867}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M remoting/codec/webrtc_video_encoder_vpx.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/protocol/webrtc_transport.cc View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Sergey Ulanov
4 years, 2 months ago (2016-10-06 23:06:13 UTC) #2
Irfan
lgtm https://codereview.chromium.org/2398293002/diff/1/remoting/protocol/webrtc_transport.cc File remoting/protocol/webrtc_transport.cc (right): https://codereview.chromium.org/2398293002/diff/1/remoting/protocol/webrtc_transport.cc#newcode339 remoting/protocol/webrtc_transport.cc:339: // Set bitrate range to 1-100 Mbps. Does ...
4 years, 2 months ago (2016-10-07 14:59:12 UTC) #3
Sergey Ulanov
On 2016/10/07 14:59:12, Irfan wrote: > lgtm > > https://codereview.chromium.org/2398293002/diff/1/remoting/protocol/webrtc_transport.cc > File remoting/protocol/webrtc_transport.cc (right): > ...
4 years, 2 months ago (2016-10-07 15:20:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398293002/1
4 years, 2 months ago (2016-10-07 15:20:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 15:45:10 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:47:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c410d363fdeeaa4551a4ed39526b8c065fea7d3
Cr-Commit-Position: refs/heads/master@{#423867}

Powered by Google App Engine
This is Rietveld 408576698