Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2398283002:
Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated (Closed)
DescriptionFix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated
We were relying on the ordering of WillBeginImplFrameOnThread and
DidInitializeCompositorFrameSink, which is not reliable as these calls
are async with regards to each other. This change switches to using
WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are
both compositor thread functions and will be ordered consistently.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/c70db2f7f0899c350ec8bb47bca750a3fbb87188
Cr-Commit-Position: refs/heads/master@{#423914}
Patch Set 1 #
Total comments: 4
Patch Set 2 : OutputSurface > CompositorFrameSink #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Fix flakiness in Layer Tree Host Cache Behavior test We were relying on DidInitializeCompositorFrameSink() being called after DidLoseCompositorFrameSink *only* once we had fully reinitialized the renderer. It turns out that in very rare circumstances, we could call this before the renderer was completely re-initialized. BUG=: ========== to ========== Fix flakiness in Layer Tree Host Cache Behavior test We were relying on DidInitializeCompositorFrameSink() being called after DidLoseCompositorFrameSink *only* once we had fully reinitialized the renderer. It turns out that in very rare circumstances, we could call this before the renderer was completely re-initialized. BUG=: CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== Fix flakiness in Layer Tree Host Cache Behavior test We were relying on DidInitializeCompositorFrameSink() being called after DidLoseCompositorFrameSink *only* once we had fully reinitialized the renderer. It turns out that in very rare circumstances, we could call this before the renderer was completely re-initialized. BUG=: CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix flakiness in Layer Tree Host Cache Behavior test We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Description was changed from ========== Fix flakiness in Layer Tree Host Cache Behavior test We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
ericrk@chromium.org changed reviewers: + danakj@chromium.org
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:590: // Output surface lost expectations. oops. Output surface -> CompositorFrameSink https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:601: // This is run after we have recreated our OutputSurface. and here
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/2398283002/#ps20001 (title: "OutputSurface > CompositorFrameSink")
https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... File cc/trees/layer_tree_host_unittest.cc (right): https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:590: // Output surface lost expectations. On 2016/10/06 23:37:38, danakj wrote: > oops. Output surface -> CompositorFrameSink Done. https://codereview.chromium.org/2398283002/diff/1/cc/trees/layer_tree_host_un... cc/trees/layer_tree_host_unittest.cc:601: // This is run after we have recreated our OutputSurface. On 2016/10/06 23:37:38, danakj wrote: > and here Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix flakiness in LayerTreeHostCacheBehaviorOnOutputSurfaceRecreated We were relying on the ordering of WillBeginImplFrameOnThread and DidInitializeCompositorFrameSink, which is not reliable as these calls are async with regards to each other. This change switches to using WillBeginImplFrameOnThread and DidInitializeRendererOnThread, which are both compositor thread functions and will be ordered consistently. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/c70db2f7f0899c350ec8bb47bca750a3fbb87188 Cr-Commit-Position: refs/heads/master@{#423914} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c70db2f7f0899c350ec8bb47bca750a3fbb87188 Cr-Commit-Position: refs/heads/master@{#423914} |
