Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2398253003: Early exit from autofill profile de-duplication if <2 profiles. (Closed)

Created:
4 years, 2 months ago by Roger McFarlane (Chromium)
Modified:
4 years, 2 months ago
Reviewers:
Mathieu, sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early exit from autofill profile de-duplication if <2 profiles. We can skip the entire de-decuplication flow if there aren't multiple autofill profiles to compire to one another. BUG=643356 Committed: https://crrev.com/8268475c779cbeabd0446f43b3e91ed0cc18c204 Cr-Commit-Position: refs/heads/master@{#424446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M components/autofill/core/browser/personal_data_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +7 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Roger McFarlane (Chromium)
PTAL?
4 years, 2 months ago (2016-10-07 20:11:09 UTC) #4
sebsg
LGTM!
4 years, 2 months ago (2016-10-11 14:05:15 UTC) #7
Mathieu
lgtm
4 years, 2 months ago (2016-10-11 14:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398253003/1
4 years, 2 months ago (2016-10-11 15:31:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:14:00 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:15:50 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8268475c779cbeabd0446f43b3e91ed0cc18c204
Cr-Commit-Position: refs/heads/master@{#424446}

Powered by Google App Engine
This is Rietveld 408576698