Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2398233004: [MD settings] touch-up removal of encoding settings (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] touch-up removal of encoding settings This CL changes some comments and closure compiler values to touch-up after the removal of the encodings menu. BUG=641899, 597488 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254 Cr-Commit-Position: refs/heads/master@{#424050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/font_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/font_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 2 months ago (2016-10-08 00:59:10 UTC) #5
dpapad
lgtm
4 years, 2 months ago (2016-10-08 01:06:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398233004/1
4 years, 2 months ago (2016-10-08 02:41:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 02:46:13 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:49:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254
Cr-Commit-Position: refs/heads/master@{#424050}

Powered by Google App Engine
This is Rietveld 408576698