Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2398223003: Add comment to GetSourceProfile. (Closed)

Created:
4 years, 2 months ago by alexmos
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Charlie Reis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add comment to GetSourceProfile. This is a followup to https://codereview.chromium.org/2372323003/. BUG=590068 Committed: https://crrev.com/b031e2c15bb2b17b2903dd82600d318508c9d7fe Cr-Commit-Position: refs/heads/master@{#423693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/browser_navigator.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alexmos
Lei, can you please take a look? This is adding the comment you suggested in ...
4 years, 2 months ago (2016-10-06 20:57:57 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-06 20:59:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398223003/1
4 years, 2 months ago (2016-10-06 21:13:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 21:38:42 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:40:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b031e2c15bb2b17b2903dd82600d318508c9d7fe
Cr-Commit-Position: refs/heads/master@{#423693}

Powered by Google App Engine
This is Rietveld 408576698