Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2398223002: Remove unused WindowAndroid parameter from TabModelSelectorFactory (Closed)

Created:
4 years, 2 months ago by mthiesse
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused WindowAndroid parameter from TabModelSelectorFactory BUG=653182 Committed: https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6 Cr-Commit-Position: refs/heads/master@{#423862}

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Add missed changes #

Patch Set 4 : Fix missed callsite. #

Patch Set 5 : Fix more test callsites #

Messages

Total messages: 18 (9 generated)
mthiesse
PTAL, No functional changes here.
4 years, 2 months ago (2016-10-06 19:58:46 UTC) #2
Ted C
lgtm
4 years, 2 months ago (2016-10-06 22:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398223002/40001
4 years, 2 months ago (2016-10-06 22:49:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/155951)
4 years, 2 months ago (2016-10-06 23:10:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398223002/60001
4 years, 2 months ago (2016-10-07 14:08:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/156350)
4 years, 2 months ago (2016-10-07 14:26:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398223002/80001
4 years, 2 months ago (2016-10-07 14:43:44 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-07 15:15:47 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:17:19 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/12596183761900660c2f5a8208a861e0ba19e7e6
Cr-Commit-Position: refs/heads/master@{#423862}

Powered by Google App Engine
This is Rietveld 408576698