Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2398183003: Revert of [esnext] ship String.prototype.padStart / String.prototype.padEnd (Closed)

Created:
4 years, 2 months ago by Clemens Hammacher
Modified:
4 years, 2 months ago
CC:
foolip, Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [esnext] ship String.prototype.padStart / String.prototype.padEnd (patchset #1 id:1 of https://codereview.chromium.org/2382193002/ ) Reason for revert: Causes several GC bugs, e.g. https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2858/steps/Mjsunit/logs/debug-constructed-by Original issue's description: > [esnext] ship String.prototype.padStart / String.prototype.padEnd > > Enable the --harmony-string-padding flag by default > > BUG=v8:4954 > R=adamk@chromium.org, littledan@chromium.org > > Committed: https://crrev.com/8352a0feaccfd9a19f3b38564ed2c0859dd6e3d5 > Cr-Commit-Position: refs/heads/master@{#40060} TBR=littledan@chromium.org,adamk@chromium.org,foolip@chromium.org,caitp@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4954 Committed: https://crrev.com/e5aade74fec6adc11f040ec7f1850dc5c7ac37c1 Cr-Commit-Position: refs/heads/master@{#40071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/flag-definitions.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Clemens Hammacher
Created Revert of [esnext] ship String.prototype.padStart / String.prototype.padEnd
4 years, 2 months ago (2016-10-07 08:39:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398183003/1
4 years, 2 months ago (2016-10-07 08:39:20 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-07 08:39:21 UTC) #5
titzer
On 2016/10/07 08:39:21, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 2 months ago (2016-10-07 08:40:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398183003/1
4 years, 2 months ago (2016-10-07 08:41:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 08:41:30 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 08:41:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5aade74fec6adc11f040ec7f1850dc5c7ac37c1
Cr-Commit-Position: refs/heads/master@{#40071}

Powered by Google App Engine
This is Rietveld 408576698