Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: net/url_request/url_request_ftp_job.h

Issue 2398153002: [net] Remove AuthData from net/base/auth.h. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/auth.cc ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_ftp_job.h
diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h
index d48d82d2068f1d0de37a47b6205a12e6c4c475eb..a741e525ebba3340ba144757a47df77e1366ab82 100644
--- a/net/url_request/url_request_ftp_job.h
+++ b/net/url_request/url_request_ftp_job.h
@@ -5,6 +5,7 @@
#ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
#define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
+#include <memory>
#include <string>
#include "base/macros.h"
@@ -49,6 +50,15 @@ class NET_EXPORT_PRIVATE URLRequestFtpJob : public URLRequestJob {
RequestPriority priority() const { return priority_; }
private:
+ class AuthData {
mmenke 2016/10/06 18:54:27 optional: Could just forward declare this here, m
asanka 2016/10/06 19:59:42 Done.
+ public:
+ AuthState state; // whether we need, have, or gave up on authentication.
mmenke 2016/10/06 18:54:27 While you're here, should capitalize Whether
asanka 2016/10/06 19:59:43 Done.
+ AuthCredentials credentials; // The credentials to use for auth.
+
+ AuthData();
+ ~AuthData();
+ };
+
void OnResolveProxyComplete(int result);
void StartFtpTransaction();
@@ -89,7 +99,7 @@ class NET_EXPORT_PRIVATE URLRequestFtpJob : public URLRequestJob {
bool read_in_progress_;
- scoped_refptr<AuthData> auth_data_;
+ std::unique_ptr<AuthData> auth_data_;
FtpTransactionFactory* ftp_transaction_factory_;
FtpAuthCache* ftp_auth_cache_;
« no previous file with comments | « net/base/auth.cc ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698