[net] Remove AuthData from net/base/auth.h.

[net] Remove AuthData from net/base/auth.h.

This is only used in URLRequestFtpJob.

R=mmenke@chromium.org
BUG=529319
Committed: https://crrev.com/4cdf16d3e8316fdc67b4725d8421e6c857824a24
Cr-Commit-Position: refs/heads/master@{#423706}

[asanka, 2016-10-06 17:59:31]

The CQ bit was checked by asanka@chromium.org to run a CQ dry run

[asanka, 2016-10-06 17:59:38]

PTAL?

[commit-bot: I haz the power, 2016-10-06 18:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2016-10-06 18:54:27]

LGTM.  Won't get back to your other one today.

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
File net/url_request/url_request_ftp_job.h (right):

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
net/url_request/url_request_ftp_job.h:53: class AuthData {
optional:  Could just forward declare this here, move the definition into the cc
file.

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
net/url_request/url_request_ftp_job.h:55: AuthState state;  // whether we need,
have, or gave up on authentication.
While you're here, should capitalize Whether

[asanka, 2016-10-06 19:59:02]

The CQ bit was checked by asanka@chromium.org

[asanka, 2016-10-06 19:59:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2398153002/#ps40001
(title: "Address comments.")

[asanka, 2016-10-06 19:59:43]

Thanks!

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
File net/url_request/url_request_ftp_job.h (right):

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
net/url_request/url_request_ftp_job.h:53: class AuthData {
On 2016/10/06 at 18:54:27, mmenke wrote:
> optional:  Could just forward declare this here, move the definition into the
cc file.

Done.

https://codereview.chromium.org/2398153002/diff/20001/net/url_request/url_req...
net/url_request/url_request_ftp_job.h:55: AuthState state;  // whether we need,
have, or gave up on authentication.
On 2016/10/06 at 18:54:27, mmenke wrote:
> While you're here, should capitalize Whether

Done.

[commit-bot: I haz the power, 2016-10-06 19:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 22:00:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 22:03:55]

Description was changed from

==========
[net] Remove AuthData from net/base/auth.h.

This is only used in URLRequestFtpJob.

R=mmenke@chromium.org
BUG=529319
==========

to

==========
[net] Remove AuthData from net/base/auth.h.

This is only used in URLRequestFtpJob.

R=mmenke@chromium.org
BUG=529319

Committed: https://crrev.com/4cdf16d3e8316fdc67b4725d8421e6c857824a24
Cr-Commit-Position: refs/heads/master@{#423706}
==========

[commit-bot: I haz the power, 2016-10-06 22:03:56]

Patchset 3 (id:??) landed as
https://crrev.com/4cdf16d3e8316fdc67b4725d8421e6c857824a24
Cr-Commit-Position: refs/heads/master@{#423706}