Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2398143002: Added build files for the analyzer and analysis_server packages. (Closed)

Created:
4 years, 2 months ago by P.Y.L.
Modified:
4 years, 2 months ago
Reviewers:
jamesr, pquitslund
CC:
jamesr1, reviews_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added build files for the analyzer and analysis_server packages. This way they can be used in the Fuchsia tree. BUG= R=pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/fe9ed42b6236ed0f59fd6ea6d9517fc71d0f48f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A pkg/analysis_server/BUILD.gn View 1 chunk +25 lines, -0 lines 0 comments Download
A pkg/analyzer/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
P.Y.L.
4 years, 2 months ago (2016-10-06 17:50:09 UTC) #3
P.Y.L.
4 years, 2 months ago (2016-10-06 17:50:11 UTC) #4
jamesr
These look good to me, although they'll only really be useful in a Fuchsia build ...
4 years, 2 months ago (2016-10-06 19:23:53 UTC) #6
pquitslund
LGTM!
4 years, 2 months ago (2016-10-06 20:00:06 UTC) #7
jamesr
4 years, 2 months ago (2016-10-06 21:00:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe9ed42b6236ed0f59fd6ea6d9517fc71d0f48f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698