Enable magic window mode with new Gvr

Enable magic window mode with new Gvr

Magic window mode was disabled(not reporting phone sensor
data) here: https://codereview.chromium.org/2367673002/
The reason was new API requires an Activity instead of a
context like before. This CL moves the initialization of
GVR to chrome so CTA is available.

BUG=389343
Committed: https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72
Cr-Commit-Position: refs/heads/master@{#425035}

[bshe, 2016-10-11 14:16:42]

Patchset #3 (id:40001) has been deleted

[bshe, 2016-10-11 14:29:12]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 14:29:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 14:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 14:31:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bshe, 2016-10-11 16:50:13]

The CQ bit was checked by bshe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 16:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:09:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:09:12]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[bshe, 2016-10-11 17:45:49]

Description was changed from

==========
Enable magic window mode with new Gvr

WIP

BUG=
==========

to

==========
Enable magic window mode with new Gvr


BUG=389343
==========

[bshe, 2016-10-11 17:49:06]

Description was changed from

==========
Enable magic window mode with new Gvr


BUG=389343
==========

to

==========
Enable magic window mode with new Gvr


Magic window mode was disabled(not reporting phone sensor 
data) here: https://codereview.chromium.org/2367673002/ 
The reason was new API requires an Activity instead of a 
context like before. This CL moves the initialization of 
GVR to chrome so CTA is available.

BUG=389343
==========

[bshe, 2016-10-11 17:50:53]

bshe@chromium.org changed reviewers:
+ dtrainor@chromium.org, girard@chromium.org, mthiesse@chromium.org

[bshe, 2016-10-11 17:50:53]

mthiesse, please take a look at this CL.

+owners

girard@chromium.org: Please review changes in 
device/vr/*

dtrainor@chromium.org: Please review changes in 
everything else

[mthiesse, 2016-10-11 18:10:44]

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(left):

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:127:
public void resumeVR() {
nit: Rename to maybeResumeVR() and maybePauseVR() now that these functions may
be no-ops

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:135:
if (mNonPresentingGvrContext != null) {
Is there a reason to have both a non-presenting GVR context and VrShell active
at the same time? If the answer is technical complexity, leaving a TODO is
probably fine for now.

[bshe, 2016-10-12 19:02:17]

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(left):

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:127:
public void resumeVR() {
On 2016/10/11 18:10:44, mthiesse wrote:
> nit: Rename to maybeResumeVR() and maybePauseVR() now that these functions may
> be no-ops

Done.

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
(right):

https://codereview.chromium.org/2398103002/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java:135:
if (mNonPresentingGvrContext != null) {
On 2016/10/11 18:10:44, mthiesse wrote:
> Is there a reason to have both a non-presenting GVR context and VrShell active
> at the same time? If the answer is technical complexity, leaving a TODO is
> probably fine for now.
I can't think of any reason. And we might want to do so when we are able to
transit from WebVr presentation to ChromeVr directly. I imagine we could create
gvr factory which provide gvr_context for magic window and for presentation. I
would leave a TODO here to avoid future complicate this CL.

[mthiesse, 2016-10-12 19:10:01]

lgtm

[girard, 2016-10-12 19:42:43]

lgtm

[David Trainor- moved to gerrit, 2016-10-13 03:24:14]

lgtm!

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContext.java
(right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContext.java:28:
public long getNativeGvrContext() {
@Override's

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextInterface.java
(right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextInterface.java:11:
public interface NonPresentingGvrContextInterface {
Remove "Interface" and call the other class NonPresentingGvrContextImpl?

https://codereview.chromium.org/2398103002/diff/100001/chrome/browser/android...
File chrome/browser/android/vr_shell/vr_shell_delegate.cc (right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/browser/android...
chrome/browser/android/vr_shell/vr_shell_delegate.cc:24: virtual
~GvrNonPresentingDelegate() {}
= default;

[bshe, 2016-10-13 14:06:28]

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContext.java
(right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContext.java:28:
public long getNativeGvrContext() {
On 2016/10/13 03:24:13, David Trainor wrote:
> @Override's

Done.

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextInterface.java
(right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/NonPresentingGvrContextInterface.java:11:
public interface NonPresentingGvrContextInterface {
On 2016/10/13 03:24:14, David Trainor wrote:
> Remove "Interface" and call the other class NonPresentingGvrContextImpl?

I copied this pattern from VrShellInterface and VrShell. I will do a follow up
CL to change file and class names to have a better isolation.

https://codereview.chromium.org/2398103002/diff/100001/chrome/browser/android...
File chrome/browser/android/vr_shell/vr_shell_delegate.cc (right):

https://codereview.chromium.org/2398103002/diff/100001/chrome/browser/android...
chrome/browser/android/vr_shell/vr_shell_delegate.cc:24: virtual
~GvrNonPresentingDelegate() {}
On 2016/10/13 03:24:14, David Trainor wrote:
> = default;

Done.

[bshe, 2016-10-13 14:08:24]

The CQ bit was checked by bshe@chromium.org

[bshe, 2016-10-13 14:08:24]

The patchset sent to the CQ was uploaded after l-g-t-m from girard@chromium.org,
dtrainor@chromium.org, mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2398103002/#ps120001
(title: "reviews")

[commit-bot: I haz the power, 2016-10-13 14:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 15:15:06]

Description was changed from

==========
Enable magic window mode with new Gvr


Magic window mode was disabled(not reporting phone sensor 
data) here: https://codereview.chromium.org/2367673002/ 
The reason was new API requires an Activity instead of a 
context like before. This CL moves the initialization of 
GVR to chrome so CTA is available.

BUG=389343
==========

to

==========
Enable magic window mode with new Gvr


Magic window mode was disabled(not reporting phone sensor 
data) here: https://codereview.chromium.org/2367673002/ 
The reason was new API requires an Activity instead of a 
context like before. This CL moves the initialization of 
GVR to chrome so CTA is available.

BUG=389343
==========

[commit-bot: I haz the power, 2016-10-13 15:15:12]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-10-13 15:16:53]

Description was changed from

==========
Enable magic window mode with new Gvr


Magic window mode was disabled(not reporting phone sensor 
data) here: https://codereview.chromium.org/2367673002/ 
The reason was new API requires an Activity instead of a 
context like before. This CL moves the initialization of 
GVR to chrome so CTA is available.

BUG=389343
==========

to

==========
Enable magic window mode with new Gvr

Magic window mode was disabled(not reporting phone sensor
data) here: https://codereview.chromium.org/2367673002/
The reason was new API requires an Activity instead of a
context like before. This CL moves the initialization of
GVR to chrome so CTA is available.

BUG=389343

Committed: https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72
Cr-Commit-Position: refs/heads/master@{#425035}
==========

[commit-bot: I haz the power, 2016-10-13 15:16:54]

Patchset 6 (id:??) landed as
https://crrev.com/75ec67ea320306345e2d2b2f7750de9b8998dc72
Cr-Commit-Position: refs/heads/master@{#425035}