Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 23981004: Synced Notifications Layout Changes (Closed)

Created:
7 years, 3 months ago by Pete Williamson
Modified:
7 years, 3 months ago
Reviewers:
dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Synced Notifications Layout Changes Per latest designs from UX, move to the 3 line format provided by the Notification Center, remove all multi-line notification data, and always use the first profile image photo instead of the app icon for multiple senders. BUG=281520 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222157

Patch Set 1 #

Total comments: 2

Patch Set 2 : Layout Changes - fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -31 lines) Patch
M chrome/browser/notifications/sync_notifier/synced_notification.cc View 4 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Pete Williamson
7 years, 3 months ago (2013-09-05 23:29:33 UTC) #1
dewittj
https://codereview.chromium.org/23981004/diff/1/chrome/browser/notifications/sync_notifier/synced_notification.cc File chrome/browser/notifications/sync_notifier/synced_notification.cc (left): https://codereview.chromium.org/23981004/diff/1/chrome/browser/notifications/sync_notifier/synced_notification.cc#oldcode222 chrome/browser/notifications/sync_notifier/synced_notification.cc:222: int notification_count = GetNotificationCount(); If we're not showing this ...
7 years, 3 months ago (2013-09-05 23:39:43 UTC) #2
Pete Williamson
https://codereview.chromium.org/23981004/diff/1/chrome/browser/notifications/sync_notifier/synced_notification.cc File chrome/browser/notifications/sync_notifier/synced_notification.cc (left): https://codereview.chromium.org/23981004/diff/1/chrome/browser/notifications/sync_notifier/synced_notification.cc#oldcode222 chrome/browser/notifications/sync_notifier/synced_notification.cc:222: int notification_count = GetNotificationCount(); On 2013/09/05 23:39:43, dewittj wrote: ...
7 years, 3 months ago (2013-09-06 21:01:42 UTC) #3
dewittj
lgtm
7 years, 3 months ago (2013-09-09 16:07:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/23981004/1
7 years, 3 months ago (2013-09-09 17:24:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=75314
7 years, 3 months ago (2013-09-09 18:29:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petewil@chromium.org/23981004/27001
7 years, 3 months ago (2013-09-09 20:32:03 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 00:41:13 UTC) #8
Message was sent while issue was closed.
Change committed as 222157

Powered by Google App Engine
This is Rietveld 408576698