Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2398073002:
Upgrade libsrtp to version 2.0 (Closed)
|
Created:
4 years, 2 months ago by mattdr-at-chromium Modified:
4 years, 2 months ago CC:
chromium-reviews, webrtc-perf-sheriffs_google.com Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpgrade libsrtp to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63..eccff9b52186
$ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s'
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=webrtc:6376
Committed: https://crrev.com/bf2e39f3e02a38491c70fa15897b0dcde1f77fba
Cr-Commit-Position: refs/heads/master@{#425002}
Patch Set 1 #Patch Set 2 : Fix BUILD.gn. Fix fuzzer. One more commit in libsrtp. #Patch Set 3 : bring in changes to libsrtp_fuzzer #Patch Set 4 : Roll new libsrtp2 change #
Messages
Total messages: 36 (25 generated)
mattdr@chromium.org changed reviewers: + kjellander@chromium.org
The CQ bit was checked by mattdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2016/10/06 13:56:40, mattdr-at-chromium wrote: Withdrawn for now. I forgot to make the necessary changes in externalhmac.h / externalhmac.cc because those files don't build as part of WebRTC standalone.
Description was changed from ========== Roll src/third_party/libsrtp/ b17c065a8..7baef7097 (1 commit). https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..7baef7097 --date=short --no-merges --format='%ad %ae %s' 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ========== to ========== Upgrade libsrtp2 to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up a few remaining clients. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..f9b21879f --date=short --no-merges --format='%ad %ae %s' 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ==========
The CQ bit was checked by mattdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Upgrade libsrtp2 to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up a few remaining clients.
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...
$ git log b17c065a8..f9b21879f --date=short --no-merges --format='%ad
%ae %s'
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=webrtc:6376
==========
to
==========
Upgrade libsrtp2 to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up a few remaining clients.
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...
$ git log b17c065a8..f9b21879f --date=short --no-merges --format='%ad %ae %s'
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=webrtc:6376
==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by mattdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
On 2016/10/06 14:11:27, mattdr-at-chromium wrote: > On 2016/10/06 13:56:40, mattdr-at-chromium wrote: > > Withdrawn for now. I forgot to make the necessary changes in externalhmac.h / > externalhmac.cc because those files don't build as part of WebRTC standalone. The Windows trybots will be fixed with https://codereview.chromium.org/2414633002/
Description was changed from
==========
Upgrade libsrtp2 to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up a few remaining clients.
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...
$ git log b17c065a8..f9b21879f --date=short --no-merges --format='%ad %ae %s'
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=webrtc:6376
==========
to
==========
Upgrade libsrtp2 to version 2.0
Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client.
https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63...
$ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s'
2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC
2016-10-10 kjellander Make libsrtp configuration public
2016-10-06 kjellander Update libsrtp to version 2.0
BUG=webrtc:6376
==========
The CQ bit was checked by mattdr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Exceeded global retry quota
Description was changed from ========== Upgrade libsrtp2 to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ==========
mattdr@chromium.org changed reviewers: + jochen@chromium.org, mmoroz@chromium.org
+jochen for BUILD.gn and mmoroz for libfuzzer
lgtm
LGTM
lgtm
The CQ bit was checked by mattdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 ========== to ========== Upgrade libsrtp to version 2.0 Roll DEPS for libsrtp to pick up version 2.0. Fix up remaining client. https://chromium.googlesource.com/chromium/deps/libsrtp.git/+log/b17c065a8a63... $ git log b17c065a8..eccff9b52 --date=short --no-merges --format='%ad %ae %s' 2016-10-12 kjellander Disable warning for signed/unsigned mismatch in MSVC 2016-10-10 kjellander Make libsrtp configuration public 2016-10-06 kjellander Update libsrtp to version 2.0 BUG=webrtc:6376 Committed: https://crrev.com/bf2e39f3e02a38491c70fa15897b0dcde1f77fba Cr-Commit-Position: refs/heads/master@{#425002} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/bf2e39f3e02a38491c70fa15897b0dcde1f77fba Cr-Commit-Position: refs/heads/master@{#425002}
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2419733003/ by tnagel@chromium.org. The reason for reverting is: Breaks the build. Reverting on behalf of Matthew.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
