Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2398063003: chromeos: Update ARC file task code to use action strings. (Closed)

Created:
4 years, 2 months ago by Daniel Erat
Modified:
4 years, 2 months ago
Reviewers:
Yusuke Sato, kinaba
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, hidehiko+watch_chromium.org, davemoore+watch_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Update ARC file task code to use action strings. Make arc_file_tasks.cc use the IntentHandlerInfo struct's string "action" field rather than the ActionType enum. ActionTypes are still used when calling HandleUrlList. BUG=647802 TEST=manual: still able to launch ARC apps for individual files or send multiple files from files app Committed: https://crrev.com/76b5a10e3b8b043793638c3737b9c4685ee8cb09 Cr-Commit-Position: refs/heads/master@{#423797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -22 lines) Patch
M chrome/browser/chromeos/file_manager/arc_file_tasks.cc View 5 chunks +27 lines, -22 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/arc/intent_helper/intent_constants.h View 1 chunk +18 lines, -0 lines 0 comments Download
A components/arc/intent_helper/intent_constants.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Daniel Erat
FYI dcheng@ per request on https://codereview.chromium.org/2396633002/
4 years, 2 months ago (2016-10-07 00:41:21 UTC) #2
Yusuke Sato
c/arc/ lgtm
4 years, 2 months ago (2016-10-07 03:44:32 UTC) #7
kinaba
lgtm
4 years, 2 months ago (2016-10-07 03:48:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398063003/1
4 years, 2 months ago (2016-10-07 05:01:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 05:07:17 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 05:08:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b5a10e3b8b043793638c3737b9c4685ee8cb09
Cr-Commit-Position: refs/heads/master@{#423797}

Powered by Google App Engine
This is Rietveld 408576698