Fixup MSan embeddertests

Fixup MSan embeddertests

The embeddertests were closing the document before the formfill environment.
This caused a use-after-free as we try to use the document during formfill
destruction.

This Cl fixes the destruction order in the embedder tests. As well, a few guards
are put in place to keep the system from crashing if the wrong destruction
order is called.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/ca03f7a1c654709152a411f665ce38c3626582e8

[dsinclair, 2016-10-06 13:17:36]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 13:17:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-06 13:17:48]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-10-06 13:17:49]

PTAL.

[commit-bot: I haz the power, 2016-10-06 13:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 13:28:29]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-06 18:33:34]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-10-06 18:33:34]

lgtm

[commit-bot: I haz the power, 2016-10-06 18:33:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-06 18:48:06]

On 2016/10/06 18:33:39, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Dan, you're going to have to land this manually as tree is closed !

[Tom Sepez, 2016-10-06 18:48:13]

The CQ bit was unchecked by tsepez@chromium.org

[dsinclair, 2016-10-06 18:53:17]

Description was changed from

==========
Fixup MSan embeddertests

The embeddertests were closing the document before the formfill environment.
This caused a use-after-free as we try to use the document during formfill
destruction.

This Cl fixes the destruction order in the embedder tests. As well, a few guards
are put in place to keep the system from crashing if the wrong destruction
order is called.
==========

to

==========
Fixup MSan embeddertests

The embeddertests were closing the document before the formfill environment.
This caused a use-after-free as we try to use the document during formfill
destruction.

This Cl fixes the destruction order in the embedder tests. As well, a few guards
are put in place to keep the system from crashing if the wrong destruction
order is called.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/ca03f7a1c654709152a411f665ce38c36265...
==========

[dsinclair, 2016-10-06 18:53:18]

Committed patchset #1 (id:1) manually as
ca03f7a1c654709152a411f665ce38c3626582e8 (tree was closed).