Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: third_party/WebKit/Source/platform/network/ResourceResponse.h

Issue 2398053003: Compute ResourceResponse::suggestedFileName on the fly. (Closed)
Patch Set: clean up vestigial changes (trybots previous) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/ResourceResponse.h
diff --git a/third_party/WebKit/Source/platform/network/ResourceResponse.h b/third_party/WebKit/Source/platform/network/ResourceResponse.h
index 49324615967e23b69f5c00ee4cf26f10d9486fc1..1dd452e2742802cfef5dc9bedfc1fddda769dba4 100644
--- a/third_party/WebKit/Source/platform/network/ResourceResponse.h
+++ b/third_party/WebKit/Source/platform/network/ResourceResponse.h
@@ -156,13 +156,6 @@ class PLATFORM_EXPORT ResourceResponse final {
const AtomicString& textEncodingName() const;
void setTextEncodingName(const AtomicString&);
- // FIXME: Should compute this on the fly.
- // There should not be a setter exposed, as suggested file name is determined
- // based on other headers in a manner that WebCore does not necessarily know
- // about.
- const String& suggestedFilename() const;
- void setSuggestedFilename(const String&);
-
int httpStatusCode() const;
void setHTTPStatusCode(int);
@@ -366,7 +359,6 @@ class PLATFORM_EXPORT ResourceResponse final {
AtomicString m_mimeType;
long long m_expectedContentLength;
AtomicString m_textEncodingName;
- String m_suggestedFilename;
int m_httpStatusCode;
AtomicString m_httpStatusText;
HTTPHeaderMap m_httpHeaderFields;
@@ -510,7 +502,6 @@ struct CrossThreadResourceResponseData {
String m_mimeType;
long long m_expectedContentLength;
String m_textEncodingName;
- String m_suggestedFilename;
int m_httpStatusCode;
String m_httpStatusText;
std::unique_ptr<CrossThreadHTTPHeaderMapData> m_httpHeaders;

Powered by Google App Engine
This is Rietveld 408576698