third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html - Issue 2398043002: [css-grid] Stretch should grow and shrink items to fit its grid area

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html

Issue 2398043002: [css-grid] Stretch should grow and shrink items to fit its grid area (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto.html ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html

index bc70b5c442844606d98de34e1add627f8b3f08f3..1319372934e7d6c01b053851bd7382a9b7bbe887 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/min-width-height-auto-and-margins.html

@@ -43,7 +43,7 @@

<p>Stretching allowed in both axis | column smaller than content-box, row bigger than margin-box</p>

- <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="100" data-expected-height="60">XXXX</div>

+ <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="40" data-expected-height="60">XXXX</div>

</div>

@@ -115,7 +115,7 @@

<p>Stretching allowed in both axis | row smaller than content-box, column bigger than margin-box</p>

- <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="110" data-expected-height="25">XXXX</div>

+ <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="110" data-expected-height="0">XXXX</div>

jfernandez 2016/10/06 10:23:28 Why 0 ?

Manuel Rego 2016/10/06 10:41:36 The row is 20px height, and the item has 20px marg

</div>

@@ -129,7 +129,7 @@

<p>Stretching allowed in both axis | row bigger than content-box, column bigger column margin-box</p>

- <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="110" data-expected-height="25">XXXX</div>

+ <div class="item" data-offset-x="20" data-offset-y="20" data-expected-width="110" data-expected-height="10">XXXX</div>

</div>