Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(89)

Issue 2398033002: Fix assertion failure when decoding malform G4 fax image (Closed)

Created:
3 years, 11 months ago by kcwu
Modified:
3 years, 11 months ago
Reviewers:
npm, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix assertion failure when decoding malform G4 fax image The position indexes of color elements must be monotonic increasing. Bail out if the decoded index is less or equal to the previous index. BUG=pdfium:615 Committed: https://pdfium.googlesource.com/pdfium/+/3a0a808ff546b5633a2384f4ed156b7ced605c90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M core/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kcwu
3 years, 11 months ago (2016-10-06 10:47:10 UTC) #2
kcwu
I proposed this fix according to my study of G4 compression spec https://www.itu.int/rec/T-REC-T.6-198811-I/en . I ...
3 years, 11 months ago (2016-10-06 11:05:34 UTC) #3
dsinclair
lgtm
3 years, 11 months ago (2016-10-06 13:03:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2398033002/1
3 years, 11 months ago (2016-10-06 13:03:19 UTC) #7
dsinclair
On 2016/10/06 11:05:34, kcwu wrote: > I proposed this fix according to my study of ...
3 years, 11 months ago (2016-10-06 13:03:31 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2016-10-06 19:29:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3a0a808ff546b5633a2384f4ed156b7ced60...

Powered by Google App Engine
This is Rietveld 408576698